Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timestamp in sc #612

Merged
merged 4 commits into from
Oct 18, 2022
Merged

Add timestamp in sc #612

merged 4 commits into from
Oct 18, 2022

Conversation

samuelmanzanera
Copy link
Member

Description

Fixes #609

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@samuelmanzanera samuelmanzanera added feature New feature request smart contracts Involve smart contracts labels Oct 7, 2022
@samuelmanzanera samuelmanzanera force-pushed the add_timestamp_in_SC branch 3 times, most recently from 56497ec to d342fd8 Compare October 10, 2022 07:10
@samuelmanzanera samuelmanzanera self-assigned this Oct 11, 2022
Copy link
Member

@Neylix Neylix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's working well, but need to add the timestamp field in the list of authorized condition in Archethic.Contracts.Contract.Conditions to be able to use it in condition block

@samuelmanzanera samuelmanzanera merged commit 6eff994 into develop Oct 18, 2022
@samuelmanzanera samuelmanzanera deleted the add_timestamp_in_SC branch October 18, 2022 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature request smart contracts Involve smart contracts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants