Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve node detection #605

Merged

Conversation

Neylix
Copy link
Member

@Neylix Neylix commented Oct 5, 2022

Description

Fixes #604

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

To test hard timeout:

  • Run 3 nodes and wait them to be authorized
  • Update the runtime of one node to change the price received by coingecko api, as so transactions will failed and node detection will be triggered until hard_timeout

in lib/archethic/oracle_chain/services/uco_price/providers/coingecko.ex replace the function fetch like this :

def fetch(pairs) when is_list(pairs) do
  {:ok, %{"eur" => 10, "usd" => 10}}
end

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@samuelmanzanera samuelmanzanera merged commit 22c65ee into archethic-foundation:develop Oct 5, 2022
@Neylix Neylix deleted the Improve-node-detection branch October 5, 2022 18:04
@Neylix Neylix mentioned this pull request Oct 5, 2022
@samuelmanzanera samuelmanzanera added the bug Something isn't working label Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants