Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove decrease availability history when node goes unavailable #603

Conversation

Neylix
Copy link
Member

@Neylix Neylix commented Oct 4, 2022

Description

When a node goes globally unavailable, it's availability history goes to 0. But, for a node, there is no way to self increase it's availabilty hostory, so from the node itself it's local availability may be to 0.
As we changed previously the way we handle the availability history, decreasing availability when node goeas globally unavailable is not required anymore

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Start 2 nodes
Wait them to be authorized
Stop 1 node and wait it to be globally unavailable
Restart it just before a beacon summary time
On the next self repair the node should be globally unavailable and locally available for itself

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Epic: #321

@Neylix Neylix added bug Something isn't working self repair Involve SelfRepair mechanism labels Oct 4, 2022
@Neylix Neylix changed the base branch from master to develop October 4, 2022 12:27
@Neylix Neylix changed the title Remove decrease availability Remove decrease availability when node goes unavailable Oct 4, 2022
@Neylix Neylix changed the title Remove decrease availability when node goes unavailable Remove decrease availability history when node goes unavailable Oct 4, 2022
@samuelmanzanera samuelmanzanera added the P2P Involve P2P networking label Oct 4, 2022
@samuelmanzanera samuelmanzanera merged commit 376fe1d into archethic-foundation:develop Oct 5, 2022
@Neylix Neylix deleted the remove-decrease-availability branch October 5, 2022 18:04
@samuelmanzanera samuelmanzanera mentioned this pull request May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P2P Involve P2P networking self repair Involve SelfRepair mechanism
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants