Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smart Contracts: reschedule triggers on node responsiveness timeout #1556

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

bchamagne
Copy link
Member

Description

When a resulting contract's transaction fails to be validated, we reschedule it.
Fixes #1547

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Scenario:

  • start 2 nodes
  • create a contract that will create a failing transaction
  @version 1

  actions triggered_by: datetime, at: 1848657600 do
    Contract.set_content "that's all folks"
  end

  actions triggered_by: interval, at: "* * * * *" do
    Contract.add_uco_transfer to: "00000000000000000000000000000000000000000000000000000000000000000000", amount: 1_000_000_000
  end
  • the contract should run every minute even if the transaction cannot be validated (Insufficient funds).

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@bchamagne bchamagne added bug Something isn't working smart contracts Involve smart contracts labels Aug 26, 2024
@Neylix Neylix merged commit 6dcd4a0 into archethic-foundation:develop Sep 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working smart contracts Involve smart contracts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Worker should reschedule interval on error
2 participants