Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change derivation path for the keychain #35

Merged
merged 4 commits into from
May 31, 2022

Conversation

prix-uniris
Copy link
Contributor

@prix-uniris prix-uniris commented May 27, 2022

This is PR to Issue #34 for this repository.

Additions:
New Derivation path scheme with paths as m\650'\0'\0' (m\650'\account'\index')
New Encoding scheme for wallets as derivation paths are now inside the encoded wallet services
APDU Command Updates

  • For Address send service_index for which address needs be derived in the encoded wallet.
    • APDU Command as e0040000 + service_index(1 byte) + encrypted_key (n bytes) + encrypted_onchain_wallet (n bytes)
  • For Signature, Supply the service index for whose's derivation paths need to sign the payload aka transaction hash. For now, only support for uco transfer transaction hashes.
    • APDU Command as e0080000 + service_index(1 byte) + reciever_addr (n bytes) + amount (8 bytes) + encrypted_key (n bytes) + encrypted_onchain_wallet (n bytes)

Deletions:
Old Derivation Paths
Variable Names from bip44 to derivation paths

@prix-uniris prix-uniris self-assigned this May 27, 2022
@prix-uniris prix-uniris requested review from redDwarf03 and a user and removed request for redDwarf03 May 27, 2022 06:38
@prix-uniris prix-uniris merged commit 8af8914 into archethic-foundation:master May 31, 2022
@ghost ghost changed the title #34 Change derivation path for the keychain Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant