Conversation
Pull Request Test Coverage Report for Build 21923380512Details
💛 - Coveralls |
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the CLI end-to-end test suite by replacing the legacy Expect/TCL scripts with Jest + TypeScript tests that drive the CLI through docker compose exec, and updates CI to run the new test target.
Changes:
- Removed the Expect-based CLI test runner and individual
.expecttest scripts. - Added Jest/TypeScript CLI tests under
tests/cli/plus shared docker/CLI helpers. - Added a dedicated Jest config + npm script for CLI tests and updated the GitHub Actions workflow to run them.
Reviewed changes
Copilot reviewed 43 out of 44 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/run_cli_tests.sh | Removed legacy Expect runner script. |
| tests/cli/wallet.test.ts | Adds Jest CLI tests for wallet commands (new/show/check mnemonic). |
| tests/cli/schema.test.ts | Adds Jest CLI tests for schema creation/list/get/template. |
| tests/cli/id.test.ts | Adds Jest CLI tests for ID lifecycle (create/list/remove/resolve/backup/recover/rotate). |
| tests/cli/helpers.ts | Adds shared helpers to execute CLI/admin via docker compose exec and parse DIDs. |
| tests/cli/help.test.ts | Adds Jest CLI tests validating help output and ordering. |
| tests/cli/encryption.test.ts | Adds Jest CLI test for encrypt-file. |
| tests/cli/credential.test.ts | Adds Jest CLI tests for issuing/accepting/publishing/revealing/revoking credentials, with container file setup. |
| tests/cli/alias.test.ts | Adds Jest CLI tests for alias add/list/remove. |
| tests/cli-tests/test_cli_validate_help.expect | Removed legacy Expect-based help validation. |
| tests/cli-tests/test_cli_show_wallet.expect | Removed legacy Expect-based show-wallet validation. |
| tests/cli-tests/test_cli_show_mnemonic.expect | Removed legacy Expect-based show-mnemonic validation. |
| tests/cli-tests/test_cli_rotate_keys.expect | Removed legacy Expect-based rotate-keys validation. |
| tests/cli-tests/test_cli_revoke_credentials.expect | Removed legacy Expect-based revoke-credential validation. |
| tests/cli-tests/test_cli_reveal_credentials.expect | Removed legacy Expect-based reveal-credential validation. |
| tests/cli-tests/test_cli_resolve_id.expect | Removed legacy Expect-based resolve-id validation. |
| tests/cli-tests/test_cli_remove_id.expect | Removed legacy Expect-based remove-id validation. |
| tests/cli-tests/test_cli_remove_alias.expect | Removed legacy Expect-based remove-alias validation. |
| tests/cli-tests/test_cli_recover_id.expect | Removed legacy Expect-based recover-id validation. |
| tests/cli-tests/test_cli_publish_credential.expect | Removed legacy Expect-based publish-credential validation. |
| tests/cli-tests/test_cli_list_schema.expect | Removed legacy Expect-based list-schemas validation. |
| tests/cli-tests/test_cli_list_issue_credentials.expect | Removed legacy Expect-based list-issued/list-credentials flow validation. |
| tests/cli-tests/test_cli_list_dids.expect | Removed legacy Expect-based list-ids validation. |
| tests/cli-tests/test_cli_list_credentials.expect | Removed legacy Expect-based list-credentials validation. |
| tests/cli-tests/test_cli_list_aliases.expect | Removed legacy Expect-based list-aliases validation. |
| tests/cli-tests/test_cli_issue_credential.expect | Removed legacy Expect-based issue-credential validation. |
| tests/cli-tests/test_cli_get_schema.expect | Removed legacy Expect-based get-schema validation. |
| tests/cli-tests/test_cli_get_credential_by_id.expect | Removed legacy Expect-based get-credential validation. |
| tests/cli-tests/test_cli_encrypt_file.expect | Removed legacy Expect-based encrypt-file validation. |
| tests/cli-tests/test_cli_create_wallet.expect | Removed legacy Expect-based create-wallet/new-wallet validation. |
| tests/cli-tests/test_cli_create_schema_template.expect | Removed legacy Expect-based create-schema-template validation. |
| tests/cli-tests/test_cli_create_schema.expect | Removed legacy Expect-based create-schema validation. |
| tests/cli-tests/test_cli_create_id.expect | Removed legacy Expect-based create-id validation. |
| tests/cli-tests/test_cli_check_wallet.expect | Removed legacy Expect-based check-wallet validation. |
| tests/cli-tests/test_cli_check_list_ids.expect | Removed legacy Expect-based list-ids validation. |
| tests/cli-tests/test_cli_backup_id.expect | Removed legacy Expect-based backup-id validation. |
| tests/cli-tests/test_cli_add_alias.expect | Removed legacy Expect-based add-alias validation. |
| tests/cli-tests/README.md | Removed legacy documentation specific to the Expect-based runner. |
| test.env | Adds a committed env file intended for tests/CI configuration. |
| package.json | Adds test:cli script to run the dedicated CLI Jest suite. |
| jest.config.js | Excludes tests/cli/ from the default Jest run. |
| jest.config.cli.js | Adds dedicated Jest configuration for CLI tests. |
| .github/workflows/docker-build-test.yml | Updates CI to install Node deps and run npm run test:cli instead of Expect-based scripts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.