Conversation
Pull Request Test Coverage Report for Build 21918404624Details
💛 - Coveralls |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the “DID names” concept to “aliases” across the Keymaster ecosystem (server API, JS/TS clients, Python SDK, CLI, UIs, docs, and tests), and bumps the wallet format version to support migrating names → aliases.
Changes:
- Renames name-related APIs and storage (
names→aliases,addName/listNames/...→addAlias/listAliases/...) across server, clients, CLI, SDKs, and UIs. - Updates wallet schema/versioning (wallet
version: 2) and adds upgrade logic to migrate legacy wallets. - Updates documentation and test suites (unit tests + CLI expect scripts) to match new terminology and endpoints.
Reviewed changes
Copilot reviewed 86 out of 86 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/keymaster/wallet.test.ts | Updates wallet version assertions and renames wallet name operations/results to alias equivalents. |
| tests/keymaster/utils.test.ts | Updates resolve-by-name test to use alias APIs. |
| tests/keymaster/image.test.ts | Updates image creation option from name to alias. |
| tests/keymaster/group.test.ts | Updates group tests to use alias terminology and alias APIs. |
| tests/keymaster/document.test.ts | Updates document creation options to use alias. |
| tests/keymaster/dmail.test.ts | Updates recipient-list and asset creation tests to use alias APIs/options. |
| tests/keymaster/client.test.ts | Updates client endpoint paths and client methods from names to aliases. |
| tests/keymaster/asset.test.ts | Updates asset creation options and error message assertions to alias naming. |
| tests/keymaster/alias.test.ts | Renames “name system” tests to “alias system” and updates expected wallet fields/errors. |
| tests/cli-tests/test_cli_validate_help.expect | Updates CLI help output expectations to alias commands. |
| tests/cli-tests/test_cli_show_wallet.expect | Updates expected wallet version to 2. |
| tests/cli-tests/test_cli_show_mnemonic.expect | Updates expected wallet version to 2. |
| tests/cli-tests/test_cli_rotate_keys.expect | Updates expected wallet version to 2. |
| tests/cli-tests/test_cli_revoke_credentials.expect | Updates expected wallet version and CLI options (-n→-a). |
| tests/cli-tests/test_cli_reveal_credentials.expect | Updates expected wallet version and CLI options (-n→-a). |
| tests/cli-tests/test_cli_resolve_id.expect | Updates expected wallet version to 2. |
| tests/cli-tests/test_cli_remove_id.expect | Updates expected wallet version to 2. |
| tests/cli-tests/test_cli_remove_alias.expect | Updates scripted CLI interactions to alias commands/output. |
| tests/cli-tests/test_cli_recover_id.expect | Updates scripted CLI interactions to alias commands. |
| tests/cli-tests/test_cli_publish_credential.expect | Updates expected wallet version and CLI options (-n→-a). |
| tests/cli-tests/test_cli_list_schema.expect | Updates expected wallet version to 2. |
| tests/cli-tests/test_cli_list_issue_credentials.expect | Updates expected wallet version and CLI options (-n→-a). |
| tests/cli-tests/test_cli_list_dids.expect | Updates expected wallet version to 2. |
| tests/cli-tests/test_cli_list_credentials.expect | Updates expected wallet version and CLI options (-n→-a). |
| tests/cli-tests/test_cli_list_aliases.expect | Updates scripted CLI interactions to alias commands. |
| tests/cli-tests/test_cli_issue_credential.expect | Updates expected wallet version and CLI options (-n→-a). |
| tests/cli-tests/test_cli_get_schema.expect | Updates expected wallet version to 2. |
| tests/cli-tests/test_cli_get_credential_by_id.expect | Updates expected wallet version and CLI options (-n→-a). |
| tests/cli-tests/test_cli_encrypt_file.expect | Updates expected wallet version to 2. |
| tests/cli-tests/test_cli_create_wallet.expect | Updates expected wallet version to 2. |
| tests/cli-tests/test_cli_create_schema_template.expect | Updates expected wallet version to 2. |
| tests/cli-tests/test_cli_create_schema.expect | Updates expected wallet version to 2. |
| tests/cli-tests/test_cli_create_id.expect | Updates expected wallet version to 2. |
| tests/cli-tests/test_cli_check_wallet.expect | Updates expected wallet version to 2. |
| tests/cli-tests/test_cli_check_list_ids.expect | Updates expected wallet version to 2. |
| tests/cli-tests/test_cli_backup_id.expect | Updates expected wallet version to 2. |
| tests/cli-tests/test_cli_add_alias.expect | Updates scripted CLI interactions to alias commands/output. |
| tests/cli-tests/hyperswarm/test_cli_import_wallet.expect | Updates expected wallet version to 2. |
| services/keymaster/server/src/keymaster-api.ts | Renames REST endpoints /names→/aliases and updates Swagger schema/fields. |
| services/keymaster/client/src/KeymasterUI.js | Updates web client UI logic to use alias lists and alias operations. |
| services/gatekeeper/client/src/KeymasterUI.js | Updates gatekeeper web UI logic to use alias lists and alias operations. |
| scripts/archon-cli.js | Updates legacy CLI script commands/options from names to aliases. |
| python/keymaster_sdk/tests/test_keymaster_sdk.py | Updates SDK tests to use alias APIs. |
| python/keymaster_sdk/src/keymaster_sdk/keymaster_sdk.py | Renames SDK functions and endpoints from names to aliases. |
| python/keymaster_sdk/src/keymaster_sdk/init.py | Updates package exports for alias functions. |
| packages/keymaster/src/types.ts | Renames wallet/type fields and Keymaster interface from names to aliases; updates option names. |
| packages/keymaster/src/keymaster.ts | Implements wallet v2 + migration (names→aliases) and renames internal alias APIs. |
| packages/keymaster/src/keymaster-client.ts | Updates client implementation to call /aliases endpoints and renamed methods. |
| packages/keymaster/src/db/typeGuards.ts | Updates wallet type guards to accept wallet versions 1 and 2. |
| packages/keymaster/src/cli.ts | Updates TS CLI to alias commands/options and output field names. |
| packages/keymaster/README.md | Updates CLI docs to alias commands and --alias option. |
| doc/keymaster-api.json | Updates generated API spec from names to aliases and related schema fields. |
| doc/03-clients/02-webui/04-dids.md | Updates Web UI docs wording to “aliases”. |
| doc/03-clients/01-cli/README.md | Updates CLI docs command list to alias commands. |
| doc/03-clients/01-cli/08-aliased-names.md | Renames documentation page/content from “aliased names” to “aliases”. |
| doc/03-clients/01-cli/07-challenge-responses.md | Updates CLI examples to use add-alias. |
| doc/03-clients/01-cli/06-manifests.md | Updates CLI examples to use add-alias. |
| doc/03-clients/01-cli/05-credentials.md | Updates CLI examples/output samples to use aliases. |
| apps/react-wallet/src/contexts/VariablesProvider.tsx | Renames context values from nameList/nameRegistry to aliasList/aliasRegistry. |
| apps/react-wallet/src/contexts/UIContext.tsx | Renames refresh function to refreshAliases and updates alias list refresh behavior. |
| apps/react-wallet/src/components/WalletTab.tsx | Updates fixWallet result destructuring for aliases; adjusts UI messaging. |
| apps/react-wallet/src/components/VaultTab.tsx | Updates vault create/rename flows to use alias APIs and alias list. |
| apps/react-wallet/src/components/SchemaTab.tsx | Updates schema create/rename flows to use alias APIs and alias list. |
| apps/react-wallet/src/components/PollTab.tsx | Updates poll flows to use alias APIs and alias list lookups. |
| apps/react-wallet/src/components/ImageTab.tsx | Updates image upload/rename flows to use alias APIs and alias list. |
| apps/react-wallet/src/components/GroupsTab.tsx | Updates group create/rename flows and member alias resolution to alias list. |
| apps/react-wallet/src/components/DocumentTab.tsx | Updates document upload/rename flows to use alias APIs and alias list. |
| apps/react-wallet/src/components/DmailTab.tsx | Updates “open browser” tab key from names to aliases. |
| apps/react-wallet/src/components/CloneAssetTab.tsx | Updates clone options from name to alias and refresh to refreshAliases. |
| apps/react-wallet/src/components/AliasedDIDs.tsx | Renames NamedDIDs → AliasedDIDs and updates add/remove/rename to alias APIs. |
| apps/react-wallet/src/BrowserContent.tsx | Updates navigation/tab wiring to “Aliased DIDs” and aliases tab value. |
| apps/chrome-extension/src/contexts/VariablesProvider.tsx | Renames extension context values from nameList/nameRegistry to aliasList/aliasRegistry. |
| apps/chrome-extension/src/contexts/UIContext.tsx | Renames refresh function to refreshAliases and updates alias list refresh behavior. |
| apps/chrome-extension/src/components/WalletTab.tsx | Updates fixWallet result destructuring for aliases and messaging. |
| apps/chrome-extension/src/components/VaultTab.tsx | Updates vault create/rename flows to use alias APIs and alias list. |
| apps/chrome-extension/src/components/SchemaTab.tsx | Updates schema create/rename flows to use alias APIs and alias list. |
| apps/chrome-extension/src/components/PollTab.tsx | Updates poll flows to use alias APIs and alias list lookups. |
| apps/chrome-extension/src/components/IssueTab.tsx | Updates select labels/variables to alias naming. |
| apps/chrome-extension/src/components/ImageTab.tsx | Updates image upload/rename flows to use alias APIs and alias list. |
| apps/chrome-extension/src/components/GroupsTab.tsx | Updates group create/rename flows and member alias resolution to alias list. |
| apps/chrome-extension/src/components/DocumentTab.tsx | Updates document upload/rename flows to use alias APIs and alias list. |
| apps/chrome-extension/src/components/DmailTab.tsx | Updates “open browser” tab key from names to aliases. |
| apps/chrome-extension/src/components/CloneAssetTab.tsx | Updates clone options from name to alias and refresh to refreshAliases. |
| apps/chrome-extension/src/components/BrowserContent.tsx | Updates navigation/tab wiring to “Aliased DIDs” and aliases tab value. |
| apps/chrome-extension/src/components/AliasedDIDs.tsx | Renames NamedDIDs → AliasedDIDs and updates add/remove/rename to alias APIs. |
| README.md | Updates top-level CLI command list to alias commands. |
Comments suppressed due to low confidence (2)
apps/chrome-extension/src/components/AliasedDIDs.tsx:146
- Avoid automated semicolon insertion (97% of all statements in the enclosing function have an explicit semicolon).
apps/react-wallet/src/components/AliasedDIDs.tsx:142 - Avoid automated semicolon insertion (97% of all statements in the enclosing function have an explicit semicolon).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Feb 11, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.