Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

search_results view should offer a lite version for points-only, no geometry #7682

Open
4 tasks
whatisgalen opened this issue Aug 9, 2021 · 1 comment
Open
4 tasks

search_results view should offer a lite version for points-only, no geometry #7682

whatisgalen opened this issue Aug 9, 2021 · 1 comment
Assignees
@whatisgalen
Labels
Subject: Performance Subject: Search

Comments

@whatisgalen
Copy link
Member

whatisgalen commented Aug 9, 2021 •
edited
Loading

User Story

The response from the url/view search_results includes a property geometries for each hit; given that the map doesn't actually show geometries but instead shows points, if there were a "points_only" argument that could be passed to search_results then both the query and the responseJSON would be faster. Presumably export would necessitate that geometries are included. Without geometries in the response payload, the map filter still functions as normal.

Acceptance Criteria

  • Unit Tests passed
  • Documentation

Definition of Done

Ticket Background

  • Sponsored by:
  • Suggested by: @
  • Designed by: @
@chiatt
Copy link
Member

chiatt commented Aug 9, 2021

re #3239

whatisgalen added a commit that referenced this issue Aug 9, 2021
@whatisgalen
gets points_only kwarg off search_results request obj, includes geome…
467d7b6 
…tries if False re #7682
whatisgalen added a commit that referenced this issue Aug 9, 2021
@whatisgalen
imports json lib in search view, re #7682
c095f1f
whatisgalen added a commit that referenced this issue Aug 9, 2021
@whatisgalen
moves post_search_hook geom permission check into try/except if geoms…
b2531f2 
… not in es resp obj, re #7682
whatisgalen added a commit that referenced this issue Aug 9, 2021
@whatisgalen
defaults to search results point property if geometries not available…
15c58aa 
… in ZoomTo fn, re #7682
@whatisgalen whatisgalen mentioned this issue Aug 9, 2021
Closed
6 tasks
@whatisgalen whatisgalen self-assigned this Aug 9, 2021
whatisgalen added a commit that referenced this issue Aug 9, 2021
@whatisgalen
changes condition to include geometries in dsl if not points_only or …
facf1c4 
…for_export, re #7682
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@whatisgalen whatisgalen

Labels
Subject: Performance Subject: Search
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chiatt @whatisgalen