Added option to exclude properties through attribute #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eFromHistory]. Changed context and demo to support new "private" field Added Tests.
rufer7
reviewed
Dec 21, 2021
| @@ -142,7 +159,11 @@ internal static TAutoHistory AutoHistory<TAutoHistory>(this EntityEntry entry, F | |||
| { | |||
| foreach (var entry in addedEntries) | |||
| { | |||
| context.Add<TAutoHistory>(entry.AddedHistory(createHistoryFactory)); | |||
| var autoHistory = entry.AutoHistory(createHistoryFactory); | |||
There was a problem hiding this comment.
@isaacgimenez seems like this change (calling .AutoHistory instead of .AddedHistory) broke the EnsureAddedHistory functionality. Is this a mistake or is there a special reason for changing this?
There was a problem hiding this comment.
Hi @rufer7 seems like a total mistake, There was no intention on changing the behavior.
I will create a fix to revert it back on the next few days
There was a problem hiding this comment.
Hi again @rufer7
PR was done but it has not been merged yet.
Hopefully someone will look into it soon.
Regards.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add attribute to exclude properties from history changes using [ExcludeFromHistory].
Changed context and demo to support new "private" field.
Added Tests to support new feature.