Inject interrupt #23
Closed
Inject interrupt #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces an interrupt injection API for the virtual CPU and simplifies some interfaces by removing the redundant AccessWidth definitions.
- Added an inject_interrupt method on AxVCpu and its underlying trait AxArchVCpu.
- Removed AccessWidth from the public API in lib.rs and exit.rs.
- Refactored the memory management interface in hal.rs to use an associated type for better abstraction.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/vcpu.rs | Added the inject_interrupt method to AxVCpu. |
| src/lib.rs | Removed the AccessWidth export and related TODO comment. |
| src/hal.rs | Replaced multiple memory functions with an associated type MmHal. |
| src/exit.rs | Updated AxVCpuExitReason to use SysRegAddr and removed AccessWidth definitions. |
| src/arch_vcpu.rs | Added the inject_interrupt method declaration with extended documentation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.