Add and remove file from app #152
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dev-storagesdk-ref-guide ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for storagesdk-ref-guide ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
shaloo
reviewed
Oct 29, 2022
|
On 10/29/22 17:36, shalz wrote:
@shaloo commented on this pull request.
> @@ -285,4 +285,18 @@ returns `true` if required.
```js
const isPermissionRequired = await storage.checkPermission() -> boolean
+```
+
+### Add existing file to App
What is the purpose of adding a file that already exists in the Arcana Store into a dApp?
The new paradigm is that the DIDs are formally separate from the dApp, and are completely under the control of the user. Apps can require delegates, etc. to access and utilize the file.
--
Regards,
|
Grant Permission API IsPermmission Required API Add/Remove File API docs cleaned up @steel-feel pls take a look if this works.
shaloo
reviewed
Oct 31, 2022
Incorporated @steel-feel suggestions and removed delegator stuff. Add/Remove is not part of delegator but for dApp context change. Created a separate section after Delegate (Grant, ispermission) section.
shaloo
force-pushed
the
himank/AR-4804-add-and-remove-file-from-app
branch
from
6b961af to
57527be
Compare
|
@SauravKanchan @steel-feel when is this merging with the storage dev branch? I would like to make sure I uncomment the docs at the same time (docs related to remove/add File functionality). Ref: https://team-1624093970686.atlassian.net/browse/AR-5030 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Resolves or continues AR-4804.
Changes
addFilefunction to add existing file to an appChecklist
developer/AR-XXX-issue-name.