Shaloo/ar 4455 mfa #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for arcana-docs-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
anivenu
reviewed
Apr 10, 2023
anivenu
reviewed
Apr 10, 2023
anivenu
reviewed
Apr 10, 2023
anivenu
reviewed
Apr 10, 2023
anivenu
reviewed
Apr 10, 2023
anivenu
reviewed
Apr 10, 2023
anivenu
reviewed
Apr 10, 2023
anivenu
reviewed
Apr 10, 2023
anivenu
reviewed
Apr 10, 2023
anivenu
reviewed
Apr 10, 2023
anivenu
reviewed
Apr 10, 2023
anivenu
reviewed
Apr 10, 2023
anivenu
reviewed
Apr 10, 2023
Collaborator
There was a problem hiding this comment.
Couple general comments -
- Arcana ecosystem would refer to the apps building on Arcana (like how Ethereum ecosystem refers to the dapps on Eth). Arcana Network would be the Arcana layer itself.
- Need to update with latest screenshots
- Low priority comment for later when we have more bandwidth - might be useful to review docs to ensure we stay consistent to who a particular page is being addressed to (dev or user) & first person/third person speech like this comment? - https://github.com/arcana-network/auth-mkdocs/pull/38/files#r1161877291
anivenu
reviewed
Apr 10, 2023
| ## MFA Errors | ||
|
|
||
|
|
||
| | MFA Phase | Error Message | Cause | Corrective Action | |
Collaborator
There was a problem hiding this comment.
@shrinathprabhu Just confirming that these are the exact error text that shows up on the toast notifications? cc @shaloo
Co-authored-by: anivenu <88192952+anivenu@users.noreply.github.com>
Co-authored-by: anivenu <88192952+anivenu@users.noreply.github.com>
Co-authored-by: anivenu <88192952+anivenu@users.noreply.github.com>
Co-authored-by: anivenu <88192952+anivenu@users.noreply.github.com>
Co-authored-by: anivenu <88192952+anivenu@users.noreply.github.com>
Co-authored-by: anivenu <88192952+anivenu@users.noreply.github.com>
Co-authored-by: anivenu <88192952+anivenu@users.noreply.github.com>
Co-authored-by: anivenu <88192952+anivenu@users.noreply.github.com>
Co-authored-by: anivenu <88192952+anivenu@users.noreply.github.com>
Co-authored-by: anivenu <88192952+anivenu@users.noreply.github.com>
Co-authored-by: anivenu <88192952+anivenu@users.noreply.github.com>
Co-authored-by: anivenu <88192952+anivenu@users.noreply.github.com>
Co-authored-by: anivenu <88192952+anivenu@users.noreply.github.com>
Co-authored-by: anivenu <88192952+anivenu@users.noreply.github.com>
Co-authored-by: anivenu <88192952+anivenu@users.noreply.github.com>
Co-authored-by: anivenu <88192952+anivenu@users.noreply.github.com>
Co-authored-by: anivenu <88192952+anivenu@users.noreply.github.com>
Co-authored-by: anivenu <88192952+anivenu@users.noreply.github.com>
Collaborator
Author
|
@anivenu I have accepted your fb. Some of them were redundant but mixed with other updates. For now, I have included them as is. For e.g., in the user Guide for MFA you changed the text - make sure you save nnnnnn to 'As a user, make sure you save nnnn'. In the user guide, there are no multiple roles. It is meant for the user so we need not add text to clarify. Thx. |
shaloo
added a commit
that referenced
this pull request
Apr 19, 2023
* Refs: #AR-5972 release notes and migration guide draft for v1.0.4 release * typo fixes * Introduction page fixes via Anirudh * Shaloo/ar 5946 (#36) * Refs: #AR-5946 first draft of new landing page as suggested by Mayur * Fix bug via Fagun and others that I found in re-review * Fix: #AR-5946 docs landing page - new look and feel. * Refs: #AR-5946 incorporate feedback via Anirudh, Maharishi * Arcana docs is invincible! We have hacked the docusaurus react/mdx features into mkdocs based docs :-) * Update icons in the landing page * Improve JS logic * Expanded options * fix register choice options * Update docs/introduction.md Co-authored-by: anivenu <88192952+anivenu@users.noreply.github.com> * fix feedback block * Shaloo/ar 5710 billing update (#31) * Refs: First draft of billing guide and how billing is done concept update in the Dashboard User Guide * Fix: #AR-5710 billing and invoice implementation updates * cleanup * Fix: #AR-5717 show wallet update * RN updated for mobile view bug fix for the Arcana wallet * wallet width note added to RN * billing cleanup * Billing cleanup for notifications * typo fix * Remove billing error for address * Update billing address and payment method form changes * Fix: #AR-6013 cognito - no aggregate login support * Shaloo/ar 4455 mfa (#38) * Refs: #AR-4455 MFA first draft minus db guide and RN, Mig guide update * dict update * Fix: #AR-4455 MFA updates and screenshots, MFA user guide * cleanup * update layout * Fix: #AR-5940 MFA error added * Added more errors via Shrinath * Update docs/concepts/mfa.md Co-authored-by: anivenu <88192952+anivenu@users.noreply.github.com> * Update docs/concepts/mfa.md Co-authored-by: anivenu <88192952+anivenu@users.noreply.github.com> * Update docs/concepts/mfa.md Co-authored-by: anivenu <88192952+anivenu@users.noreply.github.com> * Update docs/concepts/mfa.md Co-authored-by: anivenu <88192952+anivenu@users.noreply.github.com> * Update docs/concepts/mfa.md Co-authored-by: anivenu <88192952+anivenu@users.noreply.github.com> * Update docs/concepts/mfa.md Co-authored-by: anivenu <88192952+anivenu@users.noreply.github.com> * Update docs/concepts/mfa.md Co-authored-by: anivenu <88192952+anivenu@users.noreply.github.com> * Update docs/concepts/mfa.md Co-authored-by: anivenu <88192952+anivenu@users.noreply.github.com> * Update docs/concepts/mfa.md Co-authored-by: anivenu <88192952+anivenu@users.noreply.github.com> * Update docs/concepts/mfa.md Co-authored-by: anivenu <88192952+anivenu@users.noreply.github.com> * Update docs/concepts/mfa.md Co-authored-by: anivenu <88192952+anivenu@users.noreply.github.com> * Update docs/concepts/mfa.md Co-authored-by: anivenu <88192952+anivenu@users.noreply.github.com> * Update docs/concepts/mfa.md Co-authored-by: anivenu <88192952+anivenu@users.noreply.github.com> * Update docs/user_guides/mfa/mfa_ug.md Co-authored-by: anivenu <88192952+anivenu@users.noreply.github.com> * Update docs/user_guides/mfa/mfa_ug.md Co-authored-by: anivenu <88192952+anivenu@users.noreply.github.com> * Update docs/user_guides/mfa/mfa_ug.md Co-authored-by: anivenu <88192952+anivenu@users.noreply.github.com> * Update docs/user_guides/mfa/mfa_ug.md Co-authored-by: anivenu <88192952+anivenu@users.noreply.github.com> * Update docs/user_guides/mfa/mfa_ug.md Co-authored-by: anivenu <88192952+anivenu@users.noreply.github.com> --------- Co-authored-by: anivenu <88192952+anivenu@users.noreply.github.com> * Shaloo/ar 5972 reldocs (#39) * Update MFA with enhanced wallet security content * MFA Screenshots updated, text updated as per the latest implementation in the MFA user guide and other MFA sections * Bug list updated, enhancement section updated in the release notes * cleanup and update the first screen with blue notification for enhanced wallet security * CORS issue fixed and image credits added * RN refers to product version and SDK version separately * Fix Migration Guides and Release notes with product and component version numbers * fix broken link * Fix: #AR-6024 relnotes scalability addressed, no change in doc links just the layout * Fix: #AR-6023 Product versioning discussion with Anirudh implemented for review * cleanup * Fix: #AR-6026 Broken links * Fix: #AR-6026 Broken links * Fix: #AR-6028 meta title and description for SEO optimization added via Ronak * cleanup * Fix: #AR-6028 meta title and description for SEO optimization added via Ronak * Fix: #AR-6025 external links automatically open in a new tab without having to update target for each external link via this plugin * Refs: #AR-5982 Quick Start Guide SEO link, auto-cross ref alias fix and redirect for backward compatibility fixes * update plugin * Fix: #AR-6034 alias plugin upgrade and remove hack * Refs #AR-5982 SEO cleanup for auth sdk reference guides * cleanup * Refs: #AR-5982 SEO fixes for the SOAA page and related content. * Refs: #AR-5982 About section,support, troubleshooting, validator guide SEO updates * Ensure landing page is overriden correctly --------- Co-authored-by: anivenu <88192952+anivenu@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Resolves or continues AR-4455.
Also https://team-1624093970686.atlassian.net/browse/AR-5940
Blocking dependencies
NA
Changes
MFA doc update
Checklist
developer/AR-XXX-issue-name.