Skip to content

Conversation

@dustinblack
Copy link
Member

Changes introduced with this PR

In order to better control drift that can lead to CI build failures, the Dockerfile is updated to use new Arcaflow base images where we can centrally control the OS and core dependencies.


By contributing to this repository, I agree to the contribution guidelines.

@dustinblack dustinblack requested a review from a team July 4, 2023 10:02
@dustinblack
Copy link
Member Author

Testable plugin package built by updated CI: quay.io/arcalot/arcaflow-plugin-template-python:new-baseimage_3798fde

@dustinblack dustinblack requested a review from BATMAN-JD July 4, 2023 12:11
@dustinblack
Copy link
Member Author

Dockerfiles for new osbase and buildbase base images are in this repo:
https://github.com/arcalot/arcaflow-plugin-baseimage-python

Base images are in quay here:
arcalotarcaflow-plugin-baseimage-python-osbase
arcalotarcaflow-plugin-baseimage-python-buildbase

Stage 1 of the updated Dockerfile here uses the buildbase image, which inherits the core base OS and python install from the osbase image, installs version-controlled prerequisite python modules, and sets some universal parameters.

Stage 2 of the updated Dockerfile simply uses the osbase image, standardizing the base OS (currently defined in osbase as centos:stream8) and python installs.

@dustinblack dustinblack linked an issue Jul 4, 2023 that may be closed by this pull request
Copy link
Contributor

@BATMAN-JD BATMAN-JD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an awesome change that really makes this much cleaner. Well done

@mfleader mfleader self-requested a review July 5, 2023 13:54
@mfleader mfleader self-requested a review July 5, 2023 17:54
@dustinblack dustinblack merged commit 0fdd7b5 into main Jul 5, 2023
@dustinblack dustinblack deleted the new-baseimage branch July 5, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use standardized container based images

4 participants