add release building to carpenter config #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredoconnell
approved these changes
Dec 13, 2022
Contributor
There was a problem hiding this comment.
The reference to the github repo name is good. That lowers the chance of someone forgetting to update the template, resulting in the wrong image name.
The only downside is it requires the repository name to match, but that is definitely the best practice.
It's also good to do releases for tags.
portante
suggested changes
Dec 13, 2022
jaredoconnell
approved these changes
Dec 19, 2022
Contributor
There was a problem hiding this comment.
The newest version of this is much less redundant, which is great! And I see you dynamically specified the name to address the clarity problems you were concerned about, so that's good.
Looks good to me. Just make sure you fix the CI issue before merging.
mfleader
approved these changes
Dec 21, 2022
portante
approved these changes
Jan 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes introduced with this PR
add release building to carpenter config
By contributing to this repository, I agree to the contribution guidelines.