Skip to content

Conversation

@mfleader
Copy link
Member

@mfleader mfleader commented Sep 28, 2022

Changes introduced with this PR

Add a GitHub action to call Carpenter CI to check this project meets our plugin requirements, build the plugin image, and push it to a chosen registry.

Converge project towards Arcaflow Python Plugin requirements.

By contributing to this repository, I agree to the contribution guidelines.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR seems to be a draft, please change it to a draft.

@mfleader mfleader marked this pull request as draft September 28, 2022 15:59
@mfleader mfleader marked this pull request as ready for review September 29, 2022 15:56
@mfleader mfleader self-assigned this Oct 4, 2022
@mfleader mfleader requested a review from BATMAN-JD October 4, 2022 14:22
@mfleader mfleader added documentation Improvements or additions to documentation enhancement New feature or request labels Oct 4, 2022
Copy link

@portante portante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments to consider.

Copy link

@portante portante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Contributor

@sandrobonazzola sandrobonazzola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sandrobonazzola sandrobonazzola merged commit 84969f0 into arcalot:main Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants