Move Yard into documentation task #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the yard gem is only loaded in the development environment. In our `Rakefile` initializer we expect it to be there. On travis ci only the test environment is load. This cause the now the `Rakefile` to fail on any task as the `yard` can't be required:. - update Rake to `12.2` - remove old `-rubygems` parameter as of ruby `2.0` [this is not needed anymore](http://guides.rubygems.org/make-your-own-gem/#your-first-gem)
arbox
previously requested changes
Nov 22, 2017
|
Yes but is that a issue? We are also not testing this version anymore in the CI. Please let's discuss this further in #10 |
|
@arbox Could you approve this PR so Travis won't fail all the time? |
|
Yep, you can merge it :) Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the yard gem is only loaded in the development environment.
In our
Rakefileinitializer we expect it to be there. On travis cionly the
test environment is load. This cause the now the
Rakefileto fail onany task
as the
yardcan't be required:.12.2-rubygemsparameter as of ruby2.0this is not neededanymore
close #8