Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ArborX_ENABLE with ARBORX_ENABLE #99

Merged
merged 1 commit into from
Sep 16, 2019

Conversation

Rombur
Copy link
Collaborator

@Rombur Rombur commented Sep 16, 2019

@dalg24 saw the light for Kokkos and recognized the superiority of CAPS LOCK. If we merge this PR will need to update spack.

@aprokop
Copy link
Contributor

aprokop commented Sep 16, 2019

If we merge this PR will need to update spack.

Fair enough. Should be trivial.

I also wonder why in DTK we already had SET(ARBORX_ENABLE_MPI TRUE). Nevermind, I see from the patch.

@aprokop aprokop merged commit 7017434 into arborx:master Sep 16, 2019
@aprokop aprokop deleted the arborx_enable branch September 16, 2019 21:46
@aprokop
Copy link
Contributor

aprokop commented Sep 16, 2019

Updating spack is actually a bit non-trivial. We have two versions of arborx there: 0.8-beta, and master. They would need different options. We have two choices:

  1. Do if statement in cmake_args to switch between options
    This is ugly. We'll have to do version comparison too.
  2. We could do a new release (0.8-beta2?) and replace old release in spack

I would prefer the second option. The changes are not backward compatible, so new version is warranted.

@dalg24
Copy link
Contributor

dalg24 commented Sep 16, 2019 via email

@Rombur
Copy link
Collaborator Author

Rombur commented Sep 16, 2019

It's only a beta release, we can replace it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants