Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Kokkos 3.6 #748

Merged
merged 4 commits into from
Sep 21, 2022
Merged

Require Kokkos 3.6 #748

merged 4 commits into from
Sep 21, 2022

Conversation

aprokop
Copy link
Contributor

@aprokop aprokop commented Sep 21, 2022

Just wanted to create the PR. We don't have to merge it immediately.

@aprokop aprokop added build Build and installation testing Anything to do with tests and CI labels Sep 21, 2022
Copy link
Contributor

@dalg24 dalg24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to update

additionalBuildArgs '--build-arg BASE=nvidia/cuda:11.0.3-devel-ubuntu18.04 --build-arg KOKKOS_VERSION="3.6.00" --build-arg KOKKOS_OPTIONS="-DCMAKE_CXX_EXTENSIONS=OFF -DCMAKE_CXX_COMPILER=clang++ -DKokkos_ENABLE_THREADS=ON -DKokkos_ENABLE_CUDA=ON -DKokkos_ENABLE_CUDA_LAMBDA=ON -DKokkos_ARCH_VOLTA70=ON -DCMAKE_PREFIX_PATH=/usr/lib/x86_64-linux-gnu"'

too.

Looks good other than that. I will probably open a follow up PR to cleanup the arithmetic traits.

@aprokop
Copy link
Contributor Author

aprokop commented Sep 21, 2022

We might want to update

What would you want to update it to? Remove Kokkos version or update to 3.7 to get another 3.7 build?

Looks good other than that. I will probably open a follow up PR to cleanup the arithmetic traits.

What do you want to do there?

@dalg24
Copy link
Contributor

dalg24 commented Sep 21, 2022

We might want to update

What would you want to update it to? Remove Kokkos version or update to 3.7 to get another 3.7 build?

Either.

Looks good other than that. I will probably open a follow up PR to cleanup the arithmetic traits.

What do you want to do there?

Essentially drop the ArithrmeticTraits namespace and just have using-declarations. We would keep then in KokkosExt:: until eventually the numeric traits get promoted from Kokkos::Experimental:: into the main Kokkos namespace and the minimum required version we support catches up.

@aprokop aprokop merged commit 26f67a2 into arborx:master Sep 21, 2022
@aprokop aprokop deleted the require_kokkos_3.6 branch September 21, 2022 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build and installation testing Anything to do with tests and CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants