Template BruteForce on BoundingVolume #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalg24
reviewed
Aug 17, 2022
aprokop
force-pushed
the
template_brute_force_on_bounding_volume
branch
from
1b3f7f4 to
07b7ce3
Compare
dalg24
reviewed
Aug 17, 2022
| "#define ARBORX_TEST_TREE_TYPES Tuple<ArborX::BruteForce>\n" | ||
| "#include <ArborX_Box.hpp>\n" | ||
| "template <class MemorySpace> using ArborX__BruteForce = ArborX::BruteForce<MemorySpace, ArborX::Box>;\n" | ||
| "#define ARBORX_TEST_TREE_TYPES Tuple<ArborX__BruteForce>\n" |
There was a problem hiding this comment.
It won't work without:
In file included from arborx/build/test/tstQueryTreeCallbacks_BF.cpp:6:
In file included from arborx/test/tstQueryTreeCallbacks.cpp:19:
arborx/test/ArborXTest_TreeTypeTraits.hpp:81:31: error: template template argument has different template parameters than its corresponding template template parameter
typename CartesianProduct<ARBORX_TEST_TREE_TYPES,
^
arborx/build/test/tstQueryTreeCallbacks_BF.cpp:2:46: note: expanded from macro 'ARBORX_TEST_TREE_TYPES'
#define ARBORX_TEST_TREE_TYPES Tuple<ArborX::BruteForce>
^
arborx/src/ArborX_BruteForce.hpp:26:1: note: too many template parameters in template template argument
template <typename MemorySpace, typename BoundingVolume = Box>
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arborx/test/ArborXTest_TreeTypeTraits.hpp:20:11: note: previous template template parameter is here
template <template <class> class...>
^~~~~~~~~~~~~~~~
dalg24
approved these changes
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation to using brute force for multi-dimensional data.
Realistically, it's not really
BoundingVolume, but rather someValue. But that can be changed with APIv2.