Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated distributed tree stuff #706

Merged
merged 2 commits into from
Jul 26, 2022
Merged

Remove deprecated distributed tree stuff #706

merged 2 commits into from
Jul 26, 2022

Conversation

dalg24
Copy link
Contributor

@dalg24 dalg24 commented Jul 26, 2022

Following up on #705

@aprokop
Copy link
Contributor

aprokop commented Jul 26, 2022

I thought about it, but decided against it. Distributed tree should still work, we haven't introduced bounding volume there. And I haven't looked whether there are users of this.
However, I'm fine with merging it. It's ironic, as I'm the one usually trying to drop deprecations.

@aprokop aprokop added the API User visible interface modifications label Jul 26, 2022
@dalg24
Copy link
Contributor Author

dalg24 commented Jul 26, 2022

I thought about it, but decided against it. Distributed tree should still work, we haven't introduced bounding volume there. And I haven't looked whether there are users of this.
However, I'm fine with merging it. It's ironic, as I'm the one usually trying to drop deprecations.

I'd rather fix the BVH<DeviceType> implementation that have inconsistencies between the on-node and the distributed abstractions

@aprokop aprokop merged commit 84cec56 into arborx:master Jul 26, 2022
@masterleinad masterleinad deleted the remove_deprecated_distributed_tree_stuff branch July 26, 2022 15:55
@aprokop aprokop mentioned this pull request May 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aprokop aprokop aprokop approved these changes

@masterleinad masterleinad masterleinad approved these changes

Assignees
No one assigned
Labels
API User visible interface modifications
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dalg24 @aprokop @masterleinad