Enable all experimental backends #422
Conversation
There was a problem hiding this comment.
I would have opened a pull request anyway as soon as we have kokkos/kokkos#3577 merged.
It looks good to me but I would prefer to add CI before merging.
|
I don't know about this. Is there an issue with keeping these in a branch in a fork? |
Not a major issue, this is more a convenience. Say we merge SYCL first, we create conflicts for that OpenMPTarget branch. |
|
OK. I am OK with whatever is decided. The only other point is whether this should wait until Kokkos 3.3 is released. |
It has virtually nothing to do with the upcoming release. The changes I propose are valid regardless of the Kokkos version you use. |
|
My point is that I don't know which versions of Kokkos this will work with. If I understand it right, enabling these is possible but won't work with Kokkos 3.2. |
|
Please define "won't work" |
| throw std::runtime_error("OpenMPTarget backend not available!"); | ||
| #endif | ||
|
|
||
| #ifdef KOKKOS_ENABLE_ |
There was a problem hiding this comment.
Noticed that today, but thought it was intentional to not enable SYCL by default.
These are changes that are needed to check whether ArborX can build with the Kokkos experimental backends OpenMPTarget and SYCL. I have had to make these changes manually several times and I am sure other have too. I think it is time to merge it in.
I do not believe that having this in will confuse users and expect that we will get it working soon enough.