Repository navigation
fix(artifacts): cover migration recovery and add Pi approval candidate - #938
Merged
Merged
Conversation
Exercise native conversion refusals and recovery with exact copied legacy bytes so retries and rollback cannot discard later work. Preserve the original pilot and keep simulated interruption separate from host proof.
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Keep exact suite membership and count assertions while registering the six new cutover and recovery cases. The existing conformance test now executes and validates all 160 child cases.
The installed Pi manifest uses @arbiterforge/ca-pi, but workflow preflight compared it with ca-pi and reported the wrong failure. Recognize the canonical identity while preserving the explicit refusal until Pi production approval support is qualified. CHANGELOG: Report missing Pi workflow support for the real scoped package.
Synchronize the canonical and per-host adapter identity versions with the existing patch versions so installed-root checks and startup hooks accept the matching packages. Keep the identity validation unchanged. CHANGELOG: Synchronize adapter identities with the existing patch versions.
Keep transformed ordinary Pi input outside the approval authority path. The private sole-extension candidate binds exact native dialog text to the pending artifact, host session and a fresh generation while preserving trust, cancellation, replay and stale-content refusal controls. The candidate remains absent from ordinary extension registration. Local fixtures and packaged inspection do not qualify real human approval. CHANGELOG: Add a private Pi native approval candidate with bounded input and lifecycle checks; ordinary typed workflow refusal remains in force.
Integrate the reviewed performance and documentation changes from main while retaining the isolated Pi approval candidate and ordinary workflow refusal. Advance each affected adapter one patch beyond main so packaged identity and payload version guards describe the combined source accurately. Real human approval qualification remains pending. This commit neither activates the private dialog in ordinary sessions nor changes release policy.
The independent generated-policy inventory treated five reviewed private approval implementation and test files as handwritten policy. Enroll their exact paths while retaining unknown-file refusal and canonical comparisons.
Integrate the merged Pi promotion policy consumers and Academy installer integrity checks while preserving the migration candidate's existing patch versions, private native-input producer and ordinary-host refusal. Fresh focused promotion, CI, package, dialog and generated-parity checks pass. Exact incoming installer source and reviewed security bindings are retained; installed-host and genuine human-input qualification remain open.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migration recovery needs direct coverage for stale previews, replay and edits after a checkpoint. Pi preflight also compared its scoped npm package with
ca-pi, reporting an identity mismatch before reaching the actual authority limitation. This group adds those recovery regressions, recognizes@arbiterforge/ca-pi, and adds a private native Pi approval dialog candidate for isolated qualification.The dialog is loaded explicitly in one Pi 1.0.2 process with no other extensions, tools, startup prompt or inherited context. It checks genuine host trust and session identity, then passes the native dialog return unchanged through the packaged TypeScript/Python bridge. The pending artifact digest, session, generation and one-shot receipt remain bound. Ordinary prompt input and unqualified paired approval remain refused; the helper is not registered in ordinary sessions.
The original migration pilot remains unchanged. Canonical Python and adapter copies stay synchronized. The branch now includes reviewed main
af741255ab199f8465f4ea9ee8c5c178836fcc7e, with the existing group patch versions ca 2.25.2, ca-codex 0.16.2 and ca-pi 0.17.2 preserved. Dependency inputs and release policy are unchanged.Validation:
2311c871ec9f8978fbd0d8ddf24eb5db746b1284in CI run 37870013460.The owner authorized merging finished source after current-head checks pass. Installed-host qualification remains separate: one genuine owner-entered Pi native approval and durable readback are pending. Wrong-token, replay, artifact-binding, denial, cancellation and restart controls have bounded source/native-engine regression proof; those tests are not installed TUI observations or human authority. Ordinary workflow activation remains a separate owner decision. The current Codex Windows profile lacks the supported containment needed for the remaining context/scout qualification; no machine configuration change is proposed. No actual project migration or fixture input was performed.
ADR ancestry was verified against fetched base
af741255ab199f8465f4ea9ee8c5c178836fcc7eand head2311c871ec9f8978fbd0d8ddf24eb5db746b1284; the installed verifier permits squash. Current-head CI is terminal green (76 successful checks and 5 skipped checks), including the required merge-readiness aggregate. The coordinator completed the authorized squash merge asfc35117016f47de4bbfc15195057cf57c30a8a4aat 2026-10-09T02:07:39Z. Exact-merge CI, docs and both CodeQL runs passed. CI passed all six native builds, package assembly and all 18 cold-package cells. The existing automatic release run 37875957946 passed and published ca 2.25.2, ca-codex 0.16.2 and ca-pi 0.17.2; their public release tags resolve tofc35117016f47de4bbfc15195057cf57c30a8a4a, and npm metadata for ca-pi 0.17.2 was read back. The deployed docs reference page also names this merge commit. Installed/human qualification remains open as stated above.