Skip to content

Address PR #721 review findings - #722

Merged
SUaDtL merged 1 commit into
mainfrom
codex/cross-host-pr3-review-remediation
Aug 30, 2026
Merged

SUaDtL merged 1 commit into
mainfrom
codex/cross-host-pr3-review-remediation

Conversation

@SUaDtL

@SUaDtL SUaDtL commented Aug 30, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • land the three valid CodeRabbit findings from Clarify shared core and host adapter identity #721 that were reviewed locally but missed its merge race
  • correct the post-cd codeArbiter marketplace path and keep the two Pi uninstall channels separately copyable
  • restore the candidate-only Codex packaged agents degradation entry and pin all three corrections with regression tests

Why this is separate

PR #721 merged its original head while this reviewed remediation was still local. This PR is one commit directly on that merge commit and contains only the omitted four-file docs/test delta.

Verification

  • complete mandatory Python governance matrix, including desktop boundary 27/27, resource contracts 154 pass + 1 expected skip, CI impact 61/61, and hook suite 1401/1401
  • public Codex docs 9/9; public Pi docs 13/13; consumer smoke 71 pass + 1 expected skip
  • skill portability and whitespace checks clean
  • staged gitleaks scan clean
  • exact remediation bytes previously passed site typecheck, 549 site tests with the repository's Windows-appropriate timeout, 154-page build, and 26,005-link audit
  • independent coverage/content and security/scope follow-up reviews: PASS, zero findings

Scope

Documentation and read-only documentation tests only. No plugin payload, package metadata, version, release, publication, deployment, or infrastructure change.

Ref: ADR-0031

Correct the local marketplace path, keep Pi uninstall alternatives separately copyable, and retain the Codex candidate degradation in the parity ledger.

Ref: ADR-0031
@SUaDtL

SUaDtL commented Aug 30, 2026

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 30, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

Important

Review skipped

No new commits to review since the last review.

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: c2bc728e-babb-4578-8abf-afb56a5604a9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: ce892400-8ab3-429e-bdac-fbd8b66a1139

📥 Commits

Reviewing files that changed from the base of the PR and between 1497991 and e58a796.

📒 Files selected for processing (4)
  • .github/scripts/test_public_codex_docs.py
  • CONTRIBUTING.md
  • docs/parity.md
  • site/src/content/docs/guides/uninstalling.md

Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (3)
  • GitHub Check: [CHECK] | [CORE] | Hook contract <os: windows-latest>
  • GitHub Check: [CHECK] | [CORE] | Hook contract <os: macos-latest>
  • GitHub Check: [CHECK] | [CORE] | Hook contract <os: ubuntu-latest>
🧰 Additional context used
📓 Path-based instructions (1)
Prose in this repo is part of the product — skills and commands are read and executed by agents, so an ambiguous instruction is a defect, not a style nit. Prioritise findings where prose and the mechanism it describes disagree, where a docu...

⚙️ CodeRabbit configuration file

Files:

  • docs/parity.md
  • CONTRIBUTING.md
  • site/src/content/docs/guides/uninstalling.md
🔇 Additional comments (4)
CONTRIBUTING.md (1)

47-47: LGTM!

docs/parity.md (1)

109-109: LGTM!

site/src/content/docs/guides/uninstalling.md (1)

200-202: LGTM!

.github/scripts/test_public_codex_docs.py (1)

15-15: LGTM!

Also applies to: 61-61, 73-73, 88-94, 119-119, 183-204, 231-234


📝 Walkthrough

Summary by CodeRabbit

  • Documentation

    • Updated local marketplace setup instructions to use the repository root.
    • Added a parity status entry for Codex packaged agents, including release guidance and evidence.
    • Corrected Pi uninstall instructions so both removal commands appear in separate, copyable code blocks.
  • Bug Fixes

    • Improved documentation validation for marketplace setup, uninstall instructions, and parity status formatting.

Walkthrough

The change updates public documentation examples and parity records. It adds tests for the marketplace command, Pi uninstall alternatives, and the packaged-agent parity status.

Changes

Public documentation contracts

Layer / File(s) Summary
Documentation examples and parity records
CONTRIBUTING.md, docs/parity.md, site/src/content/docs/guides/uninstalling.md
The marketplace example uses the repository root. The parity ledger adds the degraded packaged-agent entry. The Pi uninstall commands use separate shell blocks.
Documentation contract tests
.github/scripts/test_public_codex_docs.py
Tests validate the updated marketplace command, separate Pi uninstall alternatives, and the degraded packaged-agent parity row. Existing checks also receive descriptive docstrings.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to e58a7

This PR corrects installation, uninstallation, and capability documentation without changing executable product behavior, permissions, deployment, or data handling; no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 10 functions across 1 files. (3 skipped: 3…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title identifies the PR as remediation for review findings from PR #721. It is related to the changes, but it does not name the three documentation corrections.
Description check ✅ Passed The description directly explains the three documentation corrections, their scope, regression tests, and verification results.
Full details: Docstring Coverage

Explanation

Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 10 functions across 1 files. (3 skipped: 3 unsupported.)

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/cross-host-pr3-review-remediation

Warning

Central YAML configuration was ignored because it failed validation, so its settings were not applied. Fix the errors below and re-run the review:
Validation error: Too big: expected string to have <=250 characters at "tone_instructions"


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai

coderabbitai Bot commented Aug 30, 2026 •

Copy link
Copy Markdown
Contributor
⚠️ Action not completed

Already reviewed the last commit. Use @coderabbitai full review to rerun a review of the entire changeset.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@SUaDtL
SUaDtL merged commit 1e5118a into main Aug 30, 2026
46 checks passed
@SUaDtL
SUaDtL deleted the codex/cross-host-pr3-review-remediation branch August 30, 2026 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant