Skip to content

tools: make sync-core.py vendored writes atomic (reliability-005) #326

Description

@SUaDtL

Branch: feat/pi-support · Tribunal run 2026-07-17-pi-support-branch · Finding: findings/reliability/reliability-005.json
sync-core.py:105-111 in-place write; interruption leaves truncated vendored hooks. temp+os.replace.

Activity

  1. added a commit that references this issue on Jul 17, 2026
    28590a7
  2. SUaDtL commented on Jul 20, 2026

    @SUaDtL
    CollaboratorAuthor

    Verified against PR #313 head 9ed248f4: tools/sync-core.py writes each vendored hook to a sibling .tmp-sync file and then uses os.replace, preventing an interrupted write from exposing a partially written destination. test_sync_core.py exercises the atomic temporary destination's failure path and clear nonzero reporting. This finding is implemented on #313, which now carries Closes #326.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    sev:lowTribunal/triage: low severity

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions