Skip to content

fix(academy): normalize remaining product display copy - #90

Merged
SUaDtL merged 1 commit into
mainfrom
codex/academy-display-name-sources
Sep 15, 2026
Merged

SUaDtL merged 1 commit into
mainfrom
codex/academy-display-name-sources

Conversation

@SUaDtL

@SUaDtL SUaDtL commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Normalize the remaining mutable Academy display-name sources to codeArbiter while preserving frozen Preview 0.32 and earlier publication evidence, quoted commands, identifiers, packages, tags, and technical literals.

Add source-scoped regressions that inventory the protected legacy occurrences and reject the legacy casing from Preview releases after 0.32.

Scope

  • Updates 16 proven mutable display occurrences across current repository copy, generated labels, learner diagnostics, and their fixtures.
  • Preserves 95 classified legacy occurrences with an exact inventory count and digest.
  • Leaves PR fix(u02): observe real audit guard evidence #56 and U02-owned sources unchanged.
  • Creates no release or tag.

Verification

  • python -m unittest tests.test_product_naming: 4 passed.
  • Direct Preview 0.33 mutation check rejects a legacy prerequisite.
  • Affected Python suites: 172 passed.
  • Independent fresh affected-suite run: 169 passed.
  • Node site tests: 11 passed.
  • tabnanny, compileall, project-state validation, staged secret scan, diff check, and copy audit passed.
  • Independent scope and coverage review passed with no findings.
  • Independent crypto review confirmed the SHA-256 use is deterministic inventory binding only, with no authentication, key, secret, signing, encryption, or KDF behavior.

Merge evidence

  • Base: dcdc1b0ab023cd8f346e89d41a1bcb6f8a027acf
  • Head: 6b1ae7d
  • ADR lifecycle ledger: not present, so no source-ancestry merge-method override applies.

Summary by CodeRabbit

  • Documentation

    • Updated product-name capitalization to consistently use “codeArbiter” across user-facing learning materials.
  • Bug Fixes

    • Corrected product-name capitalization in validation errors and preview-site labels.
  • Tests

    • Updated automated checks to reflect the standardized “codeArbiter” naming and help prevent inconsistent naming in future publications.

Keep mutable repository copy, rendered labels, and learner diagnostics aligned with the selected product name while preserving frozen publication evidence. The release guard forces every Preview after 0.32 to retire the legacy prerequisite casing.

CHANGELOG: Use codeArbiter in current Academy copy and require future Previews to retain it.
@coderabbitai

coderabbitai Bot commented Sep 15, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: arbiterForge/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 671e8d6b-1f50-4769-9538-0bccc6b3d474

📥 Commits

Reviewing files that changed from the base of the PR and between dcdc1b0 and 6b1ae7d.

📒 Files selected for processing (8)
  • README.md
  • academy_engine/curriculum.py
  • academy_engine/lesson_actions.py
  • scripts/build_preview_site.py
  • tests/test_lesson_actions.py
  • tests/test_power_user_u01.py
  • tests/test_preview_site.py
  • tests/test_product_naming.py

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The defect was inconsistent product-name casing. Runtime errors, preview labels, README text, and test fixtures now use codeArbiter; new tests protect legacy occurrences and future publication prerequisites.

Changes

Product naming consistency

Layer / File(s) Summary
Update product display text
README.md, academy_engine/curriculum.py, academy_engine/lesson_actions.py, scripts/build_preview_site.py
Mutable product text and runtime error messages now use codeArbiter.
Align existing expectations
tests/test_lesson_actions.py, tests/test_power_user_u01.py, tests/test_preview_site.py
Existing error, scope, and rendered-label expectations use the updated casing.
Add naming guardrails
tests/test_product_naming.py
New tests track protected legacy occurrences and reject legacy product text in mutable display files and future publication prerequisites.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 6b1ae

The naming updates and related guardrails do not show an actionable merge risk.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 47.37% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 19 functions across 7 files. (1 skipped: … Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: normalizing remaining product display copy to the codeArbiter spelling across Academy files, labels, diagnostics, and fixtures.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 47.37% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 19 functions across 7 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/academy-display-name-sources

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@SUaDtL
SUaDtL merged commit 292ec7c into main Sep 15, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant