Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generic celebrate function declaration #200

Merged
merged 1 commit into from
Oct 30, 2020
Merged

Add generic celebrate function declaration #200

merged 1 commit into from
Oct 30, 2020

Conversation

aarifkhamdi
Copy link
Contributor

As RequestHandler in express defined as
interface RequestHandler<P = core.ParamsDictionary, ResBody = any, ReqBody = any, ReqQuery = core.Query> extends core.RequestHandler<P, ResBody, ReqBody, ReqQuery> { }
we also have to support parameters

@codecov-io
Copy link

codecov-io commented Oct 14, 2020

Codecov Report

Merging #200 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #200   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            4         4           
=========================================
  Hits             4         4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 653cbe5...5c3ee96. Read the comment docs.

@aarifkhamdi aarifkhamdi marked this pull request as draft October 14, 2020 13:21
@aarifkhamdi aarifkhamdi marked this pull request as ready for review October 14, 2020 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants