-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ellipsoid cutout #24
Ellipsoid cutout #24
Conversation
Any opinions on whether this is better as a reference (list of references) to the cutout shape, or whether this would be better as an "editing tool"? Right now it's a bit confusing since as soon as you pick the cutout shape, everything outside of it disappears. That can be easily addressed by making "outside of cutout" perhaps temporarily just have reduced alpha/size, so that you can "feel" the rest of the scene at least. And then maybe in the editor, have a button to "apply cutout" that would actually mark splats outside of it as deleted. Does that make sense? (I could implement that) |
I like to keep things non-destructive as long as possible (so I like „store spherical shape“ better). Maybe there’s a middle ground — how about:
What do you think? Could give that „editing feel“ but also an easy way to switch between „see all particles“ (when in edit mode) and „final object“ (leave edit mode) |
I'll play around with various options and see which one seems to work best :) |
@hybridherbst alright, so I took your PR and iterated on it a bit, can you try
Not done yet: in-scene drag handles for cutout shapes, similar to lights/colliders. Easy, but does not happen by itself :) |
Thank you! Some feedback:
|
Good points, thanks for testing! Some of them already addressed (gizmos not being visible), some will try to address, some are "uhh hard, maybe later" (undo -- since all the selection/deletion state is in GPU side data only, making that integrate with undo system is doable but a bit of a hassle :)). |
Continuing over at #31 (I don't know how to add "my" commits on top your your PR hah). Thanks for making the initial change! |
Adds a "cutout" transform field in the inspector, that, when defined, visually cuts out the splats on an ellipsoid shape. This allows interactive editing and also using the same cutout for multiple scenes.
I moved the logic from the vertex shader into SplatUtilities.compute; what I'm unsure about (but what would be great!) would be to set the deleted bits correctly too so that when exporting a new PLY only the remaining splats are exported.
Some more ideas not covered by this PR: