Wrap editor scripts with UNITY_EDITOR directives#16
Closed
francescofugazzi wants to merge 1 commit intoaras-p:mainfrom
Closed
Wrap editor scripts with UNITY_EDITOR directives#16francescofugazzi wants to merge 1 commit intoaras-p:mainfrom
francescofugazzi wants to merge 1 commit intoaras-p:mainfrom
Conversation
…ives to prevent them from being compiled in non-editor builds.
aras-p
added a commit
that referenced
this pull request
Oct 4, 2023
Owner
|
Thanks! I thought that was not needed since they are in Editor folder. But turns out, that no longer takes an effect since I added an asmdef in the parent folder (and that was needed for URP/HDRP support). I solved the issue by adding a proper asmdef to the editor folder instead, closing this PR instead. |
HIHHIYAYAYOO
pushed a commit
to HIHHIYAYAYOO/UnityGaussianSplatting
that referenced
this pull request
Nov 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrapped all editor-specific scripts with
#if UNITY_EDITOR ... #endifpreprocessor directives to ensure they are excluded from non-editor builds