Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Unity6 RenderGraph #150

Merged
merged 3 commits into from
Dec 10, 2024

Conversation

zawazawagh
Copy link
Contributor

This PR implements Unity6 RenderGraph, since current RendererPass's implementation becomes obsolete in Unity6.

If you find this implementation useful, please consider merging this PR.

Or you find more suitable way, please let me know so I can try to improve upon it.

↓RenderGraphViewer indicates this GaussianSplatRenderGraph pass is working on its system.
image

@aras-p
Copy link
Owner

aras-p commented Dec 8, 2024

@zawazawagh do you know if this can also be used on earlier Unity versions, or is it 6.0+ only?

@zawazawagh
Copy link
Contributor Author

Thank you for your fast reply.
Yes, you can use it in past Unity versions.
You can continue to use RenderPass in the current implementation until Unity2022. Only the part enclosed by the symbol is compatible with the Unity6 RenderGraph.

@zawazawagh
Copy link
Contributor Author

Oh, maybe I missunderstood your question.
Added method is only for Unity6 so I put inside symbol. In past Unity version, current RenderPass implementation can still be used.

@aras-p aras-p merged commit 7a98b4b into aras-p:main Dec 10, 2024
@aras-p
Copy link
Owner

aras-p commented Dec 10, 2024

@zawazawagh thanks! I did some follow-up fixes for this here, ff268cfc6e12b4

@zawazawagh
Copy link
Contributor Author

@aras-p Thank you for following up! Your fixes seem to be more suitable in your code, thanks.

@zawazawagh zawazawagh deleted the feature/support-rendrer-graph branch December 10, 2024 10:11
aras-p added a commit that referenced this pull request Jan 25, 2025
Looks like in earlier versions (e.g. 2022), since #150 started using
built-in matrices for sorting, it does not actually work before
Unity 6. With that, remove pre-RenderGraph code paths, and so this
now requires compatibility mode to be off.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants