Add istio friendly port names #550
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! This should be changed in helm chart, this manifests are generated from chart files. Port name can parametrized thru helm values. Best Regards, |
ajanikow
requested changes
Apr 14, 2020
This commit changes the port names in the various service definitions to follow the istio [naming convention](https://istio.io/docs/ops/configuration/traffic-management/protocol-selection/). This helps the Kube-arangodb operator play nice with both istio and observability tools like [Kiali](https://git.io/Jfesl).
sleepycat
force-pushed
the
istio-friendly-port-names
branch
from
80cc441 to
3ee9d5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the port names in the various service definitions to
follow the istio naming convention.
This helps the Kube-arangodb operator play nice with both istio and
observability tools like Kiali.