[Feature] Move Condition Actions to Internal

CHANGELOG.md

@@ -18,6 +18,7 @@
 - (Maintenance) Generate CRD with Schemas
 - (Feature) DebugPackage Improvements
 - (Feature) Improve Bootstrap time
+- (Feature) Move Condition Actions to Internal
 
 ## [1.2.47](https://github.com/arangodb/kube-arangodb/tree/1.2.47) (2025-03-28)
 - (Bugfix) Use Profile Annotations

docs/generated/actions.md

@@ -33,15 +33,15 @@ nav_order: 11
 | EnableMaintenance | no | 10m0s | no | Community & Enterprise | Enable ArangoDB maintenance mode |
 | EnableMemberMaintenance | no | 10m0s | no | Enterprise Only | Enable ArangoDB DBServer maintenance mode |
 | EncryptionKeyAdd | no | 10m0s | no | Enterprise Only | Add the encryption key to the pool |
-| EncryptionKeyPropagated | no | 10m0s | no | Enterprise Only | Update condition of encryption propagation |
+| EncryptionKeyPropagated | yes | 10m0s | no | Enterprise Only | Update condition of encryption propagation |
 | EncryptionKeyRefresh | no | 10m0s | no | Enterprise Only | Refresh the encryption keys on member |
 | EncryptionKeyRemove | no | 10m0s | no | Enterprise Only | Remove the encryption key to the pool |
 | EncryptionKeyStatusUpdate | no | 10m0s | no | Enterprise Only | Update status of encryption propagation |
 | EnforceResignLeadership | no | 45m0s | yes | Community & Enterprise | Run the ResignLeadership job on DBServer and checks data compatibility after |
 | Idle | no | 10m0s | no | Community & Enterprise | Define idle operation in case if preconditions are not meet |
 | JWTAdd | no | 10m0s | no | Enterprise Only | Adds new JWT to the pool |
 | JWTClean | no | 10m0s | no | Enterprise Only | Remove JWT key from the pool |
-| JWTPropagated | no | 10m0s | no | Enterprise Only | Update condition of JWT propagation |
+| JWTPropagated | yes | 10m0s | no | Enterprise Only | Update condition of JWT propagation |
 | JWTRefresh | no | 10m0s | no | Enterprise Only | Refresh current JWT secrets on the member |
 | JWTSetActive | no | 10m0s | no | Enterprise Only | Change active JWT key on the cluster |
 | JWTStatusUpdate | no | 10m0s | no | Enterprise Only | Update status of JWT propagation |
@@ -78,22 +78,22 @@ nav_order: 11
 | RuntimeContainerImageUpdate | no | 10m0s | no | Community & Enterprise | Update Container Image in runtime |
 | RuntimeContainerSyncTolerations | no | 10m0s | no | Community & Enterprise | Update Pod Tolerations in runtime |
 | ~~SetCondition~~ | no | 10m0s | no | Community & Enterprise | Set deployment condition |
-| SetConditionV2 | no | 10m0s | no | Community & Enterprise | Set deployment condition |
+| SetConditionV2 | yes | 10m0s | no | Community & Enterprise | Set deployment condition |
 | SetCurrentImage | no | 6h0m0s | no | Community & Enterprise | Update deployment current image after image discovery |
 | SetCurrentMemberArch | no | 10m0s | no | Community & Enterprise | Set current member architecture |
-| SetMaintenanceCondition | no | 10m0s | no | Community & Enterprise | Update ArangoDB maintenance condition |
+| SetMaintenanceCondition | yes | 10m0s | no | Community & Enterprise | Update ArangoDB maintenance condition |
 | ~~SetMemberCondition~~ | no | 10m0s | no | Community & Enterprise | Set member condition |
-| SetMemberConditionV2 | no | 10m0s | no | Community & Enterprise | Set member condition |
+| SetMemberConditionV2 | yes | 10m0s | no | Community & Enterprise | Set member condition |
 | SetMemberCurrentImage | no | 10m0s | no | Community & Enterprise | Update Member current image |
 | ShutdownMember | no | 30m0s | no | Community & Enterprise | Sends Shutdown requests and waits for container to be stopped |
 | TLSKeyStatusUpdate | no | 10m0s | no | Enterprise Only | Update Status of TLS propagation process |
-| TLSPropagated | no | 10m0s | no | Enterprise Only | Update TLS propagation condition |
+| TLSPropagated | yes | 10m0s | no | Enterprise Only | Update TLS propagation condition |
 | TimezoneSecretSet | no | 30m0s | no | Community & Enterprise | Set timezone details in cluster |
 | TopologyDisable | no | 10m0s | no | Enterprise Only | Disable TopologyAwareness |
 | TopologyEnable | no | 10m0s | no | Enterprise Only | Enable TopologyAwareness |
 | TopologyMemberAssignment | no | 10m0s | no | Enterprise Only | Update TopologyAwareness Members assignments |
 | TopologyZonesUpdate | no | 10m0s | no | Enterprise Only | Update TopologyAwareness Zones info |
-| UpToDateUpdate | no | 10m0s | no | Community & Enterprise | Update UpToDate condition |
+| UpToDateUpdate | yes | 10m0s | no | Community & Enterprise | Update UpToDate condition |
 | UpdateTLSSNI | no | 10m0s | no | Enterprise Only | Update certificate in SNI |
 | UpgradeMember | no | 6h0m0s | no | Community & Enterprise | Run the Upgrade procedure on member |
 | WaitForMemberInSync | no | 30m0s | no | Community & Enterprise | Wait for member to be in sync. In case of DBServer waits for shards. In case of Agents to catch-up on Agency index |

internal/actions.yaml

@@ -108,6 +108,7 @@ actions:
   TLSPropagated:
     enterprise: true
     description: Update TLS propagation condition
+    isInternal: true
   UpdateTLSSNI:
     enterprise: true
     description: Update certificate in SNI
@@ -135,6 +136,7 @@ actions:
     timeout: 15m
   UpToDateUpdate:
     description: Update UpToDate condition
+    isInternal: true
   BackupRestore:
     enterprise: true
     description: Restore selected Backup
@@ -158,6 +160,7 @@ actions:
   EncryptionKeyPropagated:
     enterprise: true
     description: Update condition of encryption propagation
+    isInternal: true
   JWTStatusUpdate:
     enterprise: true
     description: Update status of JWT propagation
@@ -176,6 +179,7 @@ actions:
   JWTPropagated:
     enterprise: true
     description: Update condition of JWT propagation
+    isInternal: true
   ClusterMemberCleanup:
     description: Remove member from Cluster if it is gone already (Coordinators)
   EnableMaintenance:
@@ -184,6 +188,7 @@ actions:
     description: Disable ArangoDB maintenance mode
   SetMaintenanceCondition:
     description: Update ArangoDB maintenance condition
+    isInternal: true
   EnableMemberMaintenance:
     enterprise: true
     description: Enable ArangoDB DBServer maintenance mode
@@ -211,6 +216,7 @@ actions:
     description: Set member condition
     scopes:
       - High
+    isInternal: true
   SetCondition:
     description: Set deployment condition
     scopes:
@@ -220,6 +226,7 @@ actions:
     description: Set deployment condition
     scopes:
       - High
+    isInternal: true
   MemberRIDUpdate:
     description: Update Run ID of member
     scopes:

pkg/deployment/reconcile/action.register.generated_test.go

@@ -249,7 +249,7 @@ func Test_Actions(t *testing.T) {
 	t.Run("EncryptionKeyPropagated", func(t *testing.T) {
 		ActionsExistence(t, api.ActionTypeEncryptionKeyPropagated)
 		t.Run("Internal", func(t *testing.T) {
-			require.False(t, api.ActionTypeEncryptionKeyPropagated.Internal())
+			require.True(t, api.ActionTypeEncryptionKeyPropagated.Internal())
 		})
 		t.Run("Optional", func(t *testing.T) {
 			require.False(t, api.ActionTypeEncryptionKeyPropagated.Optional())
@@ -329,7 +329,7 @@ func Test_Actions(t *testing.T) {
 	t.Run("JWTPropagated", func(t *testing.T) {
 		ActionsExistence(t, api.ActionTypeJWTPropagated)
 		t.Run("Internal", func(t *testing.T) {
-			require.False(t, api.ActionTypeJWTPropagated.Internal())
+			require.True(t, api.ActionTypeJWTPropagated.Internal())
 		})
 		t.Run("Optional", func(t *testing.T) {
 			require.False(t, api.ActionTypeJWTPropagated.Optional())
@@ -707,7 +707,7 @@ func Test_Actions(t *testing.T) {
 	t.Run("SetConditionV2", func(t *testing.T) {
 		ActionsExistence(t, api.ActionTypeSetConditionV2)
 		t.Run("Internal", func(t *testing.T) {
-			require.False(t, api.ActionTypeSetConditionV2.Internal())
+			require.True(t, api.ActionTypeSetConditionV2.Internal())
 		})
 		t.Run("Optional", func(t *testing.T) {
 			require.False(t, api.ActionTypeSetConditionV2.Optional())
@@ -737,7 +737,7 @@ func Test_Actions(t *testing.T) {
 	t.Run("SetMaintenanceCondition", func(t *testing.T) {
 		ActionsExistence(t, api.ActionTypeSetMaintenanceCondition)
 		t.Run("Internal", func(t *testing.T) {
-			require.False(t, api.ActionTypeSetMaintenanceCondition.Internal())
+			require.True(t, api.ActionTypeSetMaintenanceCondition.Internal())
 		})
 		t.Run("Optional", func(t *testing.T) {
 			require.False(t, api.ActionTypeSetMaintenanceCondition.Optional())
@@ -760,7 +760,7 @@ func Test_Actions(t *testing.T) {
 	t.Run("SetMemberConditionV2", func(t *testing.T) {
 		ActionsExistence(t, api.ActionTypeSetMemberConditionV2)
 		t.Run("Internal", func(t *testing.T) {
-			require.False(t, api.ActionTypeSetMemberConditionV2.Internal())
+			require.True(t, api.ActionTypeSetMemberConditionV2.Internal())
 		})
 		t.Run("Optional", func(t *testing.T) {
 			require.False(t, api.ActionTypeSetMemberConditionV2.Optional())
@@ -801,7 +801,7 @@ func Test_Actions(t *testing.T) {
 	t.Run("TLSPropagated", func(t *testing.T) {
 		ActionsExistence(t, api.ActionTypeTLSPropagated)
 		t.Run("Internal", func(t *testing.T) {
-			require.False(t, api.ActionTypeTLSPropagated.Internal())
+			require.True(t, api.ActionTypeTLSPropagated.Internal())
 		})
 		t.Run("Optional", func(t *testing.T) {
 			require.False(t, api.ActionTypeTLSPropagated.Optional())
@@ -861,7 +861,7 @@ func Test_Actions(t *testing.T) {
 	t.Run("UpToDateUpdate", func(t *testing.T) {
 		ActionsExistence(t, api.ActionTypeUpToDateUpdate)
 		t.Run("Internal", func(t *testing.T) {
-			require.False(t, api.ActionTypeUpToDateUpdate.Internal())
+			require.True(t, api.ActionTypeUpToDateUpdate.Internal())
 		})
 		t.Run("Optional", func(t *testing.T) {
 			require.False(t, api.ActionTypeUpToDateUpdate.Optional())