Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding authentication support #14

Merged
merged 12 commits into from
Feb 27, 2018
Merged

Adding authentication support #14

merged 12 commits into from
Feb 27, 2018

Conversation

ewoutp
Copy link
Contributor

@ewoutp ewoutp commented Feb 26, 2018 •
edited
Loading

This PR changes:

  • authentication behaviour to "default on"
  • implements JWT secret creation (if needed)
  • implements passing JWT secret to arangod containers through envvar (with secret as source)

This PR extends #13

@ewoutp ewoutp changed the title Adding authentication support (WIP) Adding authentication support Feb 26, 2018
@ewoutp ewoutp requested a review from ObiWahn February 26, 2018 15:34
kvahed
kvahed approved these changes Feb 27, 2018
View reviewed changes
Copy link
Contributor

@kvahed kvahed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ewoutp ewoutp merged commit 3066394 into master Feb 27, 2018
@ewoutp ewoutp deleted the auth branch February 27, 2018 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvahed kvahed kvahed approved these changes

@ObiWahn ObiWahn Awaiting requested review from ObiWahn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ewoutp @kvahed