Skip to content
Open
Show file tree
Hide file tree
Changes from 19 commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
26c022b
Changed TESTV2PARALLEL from 1 to 4 in Makefile
bluepal-prasanthi-moparthi Nov 20, 2025
bfc7c84
chore: trigger CircleCI
bluepal-prasanthi-moparthi Nov 20, 2025
a9e7d27
disabled parallel execution for Test_CompactDatabases and add note in…
bluepal-prasanthi-moparthi Nov 21, 2025
205d5ba
add newtimer for collection wrapper and helper function for superuser
bluepal-prasanthi-moparthi Nov 21, 2025
811e226
Removed conflict error (409) from helper_test file and removed hard c…
bluepal-prasanthi-moparthi Nov 24, 2025
1c32ba1
fix the failed test case
bluepal-prasanthi-moparthi Nov 24, 2025
9a1a890
Addressed comments given by Jakub
bluepal-prasanthi-moparthi Nov 25, 2025
b66eaa3
added log to check the exact error message
bluepal-prasanthi-moparthi Nov 25, 2025
fe5406a
add sleep in GetStartupConfiguration testcase
bluepal-prasanthi-moparthi Nov 25, 2025
385b9d0
add extract error details from the response map in GetStartupConfigur…
bluepal-prasanthi-moparthi Nov 25, 2025
c9a7546
changes to skip superuser access related testcases when auth is not …
bluepal-prasanthi-moparthi Nov 26, 2025
12eba94
modified Test_GetStartupConfiguration testcase to handle UTF-8 error
bluepal-prasanthi-moparthi Nov 26, 2025
5e43880
testcase fix
bluepal-prasanthi-moparthi Nov 26, 2025
3e74da8
removed commented code from testcases
bluepal-prasanthi-moparthi Nov 26, 2025
bc26901
testcase fix
bluepal-prasanthi-moparthi Nov 26, 2025
89f4363
chore: trigger CircleCI
bluepal-prasanthi-moparthi Nov 26, 2025
6ca525e
skip the GetStartupConfigurationDescription testcase
bluepal-prasanthi-moparthi Nov 26, 2025
9c752b5
addressed copilot comments
bluepal-prasanthi-moparthi Dec 1, 2025
96147f6
Update v2/tests/admin_test.go
bluepal-prasanthi-moparthi Dec 1, 2025
72fd56c
addressed comments
bluepal-prasanthi-moparthi Dec 1, 2025
3d26d8d
removed the skip line from GetStartupConfigurationDescription testcase
bluepal-prasanthi-moparthi Dec 1, 2025
9cb51db
comment changes
bluepal-prasanthi-moparthi Dec 1, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ ifndef VST_ENABLED
VST_ENABLED := "false"
endif

TESTV2PARALLEL ?= 1
TESTV2PARALLEL ?= 4

ORGPATH := github.com/arangodb
REPONAME := $(PROJECT)
Expand Down Expand Up @@ -417,6 +417,7 @@ COMMON_DOCKER_CMD_PARAMS = \
$(TEST_NET) \
-e TEST_ENDPOINTS=$(TEST_ENDPOINTS) \
-e TEST_NOT_WAIT_UNTIL_READY=$(TEST_NOT_WAIT_UNTIL_READY) \
-e TEST_AUTH=$(TEST_AUTH) \
-e TEST_AUTHENTICATION=$(TEST_AUTHENTICATION) \
-e TEST_JWTSECRET=$(TEST_JWTSECRET) \
-e TEST_MODE=$(TEST_MODE) \
Expand Down
1 change: 1 addition & 0 deletions v2/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## [master](https://github.com/arangodb/go-driver/tree/master) (N/A)
- Add endpoint to fetch deployment id
- Add ARM Support for V2 testcases
- Set TESTV2PARALLEL from 1 to 4

## [2.1.6](https://github.com/arangodb/go-driver/tree/v2.1.6) (2025-11-06)
- Add missing endpoints from replication
Expand Down
50 changes: 50 additions & 0 deletions v2/arangodb/client_admin_impl.go
Original file line number Diff line number Diff line change
Expand Up @@ -261,6 +261,31 @@ func (c *clientAdmin) GetStartupConfiguration(ctx context.Context) (map[string]i
case http.StatusOK:
return response, nil
default:
// Try to extract error details from the response map
// ArangoDB error responses include: error, code, errorNum, errorMessage
if errorVal, hasError := response["error"]; hasError {
if errorBool, ok := errorVal.(bool); ok && errorBool {
// This is an error response, extract error details
errorStruct := shared.ResponseStruct{}
if codeVal, ok := response["code"].(float64); ok {
codeInt := int(codeVal)
errorStruct.Code = &codeInt
}
if errorNumVal, ok := response["errorNum"].(float64); ok {
errorNumInt := int(errorNumVal)
errorStruct.ErrorNum = &errorNumInt
}
if errorMsgVal, ok := response["errorMessage"].(string); ok {
errorStruct.ErrorMessage = &errorMsgVal
}
if errorStruct.Code != nil || errorStruct.ErrorNum != nil || errorStruct.ErrorMessage != nil {
errorBool := true
errorStruct.Error = &errorBool
return nil, errorStruct.AsArangoError()
}
}
}
// Fallback to code-only error if we couldn't parse error details
return nil, (&shared.ResponseStruct{}).AsArangoErrorWithCode(code)
}
}
Expand All @@ -281,6 +306,31 @@ func (c *clientAdmin) GetStartupConfigurationDescription(ctx context.Context) (m
case http.StatusOK:
return response, nil
default:
// Try to extract error details from the response map
// ArangoDB error responses include: error, code, errorNum, errorMessage
if errorVal, hasError := response["error"]; hasError {
if errorBool, ok := errorVal.(bool); ok && errorBool {
// This is an error response, extract error details
errorStruct := shared.ResponseStruct{}
if codeVal, ok := response["code"].(float64); ok {
codeInt := int(codeVal)
errorStruct.Code = &codeInt
}
if errorNumVal, ok := response["errorNum"].(float64); ok {
errorNumInt := int(errorNumVal)
errorStruct.ErrorNum = &errorNumInt
}
if errorMsgVal, ok := response["errorMessage"].(string); ok {
errorStruct.ErrorMessage = &errorMsgVal
}
if errorStruct.Code != nil || errorStruct.ErrorNum != nil || errorStruct.ErrorMessage != nil {
errorBool := true
errorStruct.Error = &errorBool
return nil, errorStruct.AsArangoError()
}
}
}
// Fallback to code-only error if we couldn't parse error details
return nil, (&shared.ResponseStruct{}).AsArangoErrorWithCode(code)
}
}
Expand Down
Loading