Skip to content
This repository was archived by the owner on Dec 13, 2023. It is now read-only.

DOC-442 | Authentication of notebooks #1322

Merged
merged 3 commits into from
Apr 6, 2023
Merged

DOC-442 | Authentication of notebooks #1322

merged 3 commits into from
Apr 6, 2023

Conversation

nerpaula
Copy link
Contributor

@nerpaula nerpaula commented Apr 5, 2023

The authentication of notebooks has changed. Changes reflected in the docs:

  • updated screenshot
  • adjusted step about accessing a notebook

@cla-bot cla-bot bot added the cla-signed label Apr 5, 2023
@nerpaula nerpaula self-assigned this Apr 5, 2023
@nerpaula nerpaula requested a review from Robert-Stam April 5, 2023 05:31
Copy link

@Robert-Stam Robert-Stam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments, further LGTM

@Simran-B
Copy link
Collaborator

Simran-B commented Apr 5, 2023

Is there an API besides internal-dashboard that should be excluded from the permissions list?

Are the dataloader-admin and mlservices-admin roles something that should be excluded for now?

@nerpaula
Copy link
Contributor Author

nerpaula commented Apr 5, 2023

Are the dataloader-admin and mlservices-admin roles something that should be excluded for now?

AFAIK yes, these should be excluded for now. @Robert-Stam can you please confirm?

@Simran-B Simran-B requested a review from Robert-Stam April 5, 2023 10:29
@Robert-Stam
Copy link

Are the dataloader-admin and mlservices-admin roles something that should be excluded for now?

AFAIK yes, these should be excluded for now. @Robert-Stam can you please confirm?

There are in BETA , so imo can be included

@nerpaula nerpaula merged commit 0695e87 into main Apr 6, 2023
@nerpaula nerpaula deleted the DOC-442 branch April 6, 2023 06:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants