Skip to content

Conversation

@chrolivier
Copy link
Contributor

Added the full set of options on POST/PUT/PATCH/DELETE operations for GraphVertexCollection and GraphEdgeCollection operations for vertices and edges.

I would like to have reused the InsertOptions, ReplaceOptions, UpdateOptions and RemoveOptions from /src/util/types.ts but the options for graph operations are different than those of regular document collections (e.g. POST doesn't take a "silent" parameter)

@pluma
Copy link
Contributor

pluma commented Sep 23, 2019

Thanks for the PR but this functionality already existed in the feature/next-major branch and will be released as part of the next semver major update. You can follow the changes in #626.

I would have still merged this with a CLA but sadly returnNew and returnOld require breaking changes to have any effect (unlike the regular collection API the graph collection endpoints always wrap the metadata in an "edge" or "vertex" property and the "new" and "old" properties are added as siblings, not children -- arangojs currently unwraps the metadata from the property).

@pluma
Copy link
Contributor

pluma commented Sep 23, 2019

Nevermind that, I just realised there's an easy way to simply cheat by merging the additional properties into the result object: f9d1e9a

If you could port this over, this could be merged in a minor release. However for legal reasons we need a signed Contributor License Agreement (CLA) before we can merge your code into the project.

You can download the form from our website: https://www.arangodb.com/documents/cla.pdf

Once you've filled out and signed it, please send it to us via e-mail: cla@arangodb.com or fax: +49-221-2722999-88.

@pluma pluma self-assigned this Sep 23, 2019
@pluma
Copy link
Contributor

pluma commented Sep 24, 2019

Omar just informed me we already have a CLA on file. I'll merge this over as-is for now even though the returnNew and returnOld options won't have any effect.

@pluma pluma merged commit f06d1fa into arangodb:master Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants