Skip to content

Conversation

@casdevs
Copy link
Contributor

@casdevs casdevs commented Mar 4, 2018

because it was misspelled opts.spath, appending a missing leading slash wasn't working within route/request and therefore e.g. calling endpoint POST /_api/gharial/{graph-name}/vertex/{collection-name} missed the {collection-name} part, leading to error 400 child "collection" fails because ["collection" is required] when trying to add a vertex document into a vertex collection via the Http API.

because it was misspelled "opts.spath", appending a leading slash wasn't working within route/request and therefore e.g. calling endpoint "POST /_api/gharial/{graph-name}/vertex/{collection-name}" missed the "{collection-name}" part, leading to error 400 `child "collection" fails because ["collection" is required]` when trying to add a vertex document into a vertex collection via the Http API.
@pluma
Copy link
Contributor

pluma commented Mar 5, 2018

Whoops, thanks for catching that.

Although this is just a typo, for legal reasons we still need a signed Contributor License Agreement (CLA) before we can merge your code into the project.

You can download the form from our website: https://www.arangodb.com/documents/cla.pdf

Once you've filled out and signed it, please send it to us via e-mail: cla@arangodb.com or fax: +49-221-2722999-88.

@casdevs
Copy link
Contributor Author

casdevs commented Mar 5, 2018

Thanks for your quick response!
CLA sent via email to cla@arangodb.com.

Would be great if you quickly released a new version with the typo fixed so that all specified HTTP API endpoints can be used!

@sleto-it
Copy link
Contributor

sleto-it commented Mar 6, 2018

Hi @casdevs please can you check again if you sent the email. We have not received it - cla@arangodb.com

Many thanks,

@casdevs
Copy link
Contributor Author

casdevs commented Mar 6, 2018

done.

@pluma pluma merged commit 17ed0aa into arangodb:master Mar 6, 2018
pluma added a commit that referenced this pull request Mar 6, 2018
@casdevs casdevs deleted the patch-1 branch March 6, 2018 18:04
@pluma
Copy link
Contributor

pluma commented Mar 6, 2018

FYI the changes have been released as 6.2.0.

@casdevs
Copy link
Contributor Author

casdevs commented Mar 7, 2018

great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants