support transaction options #494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR. For legal reasons we need a signed Contributor License Agreement (CLA) before we can merge your code into the project. You can download the form from our website: https://www.arangodb.com/documents/cla.pdf Once you've filled out and signed it, please send it to us via e-mail: cla@arangodb.com or fax: +49-221-2722999-88. |
|
CLA Signed :) sent on the 8th Feb |
|
@f5io Thanks for submitting the CLA. Sorry this took a while, Cologne Carnival got in the way so I wasn't in the office last week. I'll have to add some logic for backwards compatibility before releasing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
I tried to make this as backwards compatible as possible, no tests break, but I am aware this is because no transaction tests exist 😱.
I would be willing to take a crack at the tests if someone can give me some guidance as to what kind of assertions I should make, or whether it would be best to unit test and stub the endpoint?