Skip to content

Conversation

@xygahs0801
Copy link

it can be used as:
import arangojs = require("arangojs");
let db = arangojs(http://${host}:${port});
db.useDatabase(database);
db.useBasicAuth(username, password);

@TimMensch
Copy link

It looks like this would break the standard/modern TypeScript/ES6 usage pattern of:

import { Database } from "arangojs";

const db = new Database({ name: "mydb" });
// ...

You should be able to add the arangojs() default function export without killing the ability to import the individual classes. This pull request makes the type definitions worse.

pluma added a commit that referenced this pull request Nov 29, 2017
We'll eventually add official typings, until then these do more harm
than good.

Closes #391, #447, #460, #472, #476.
@pluma pluma closed this Nov 29, 2017
@pluma pluma mentioned this pull request Nov 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants