Modify collection schema #388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joerg84
reviewed
Apr 27, 2021
| " }" + | ||
| " }") | ||
| .replaceAll("\\s", ""); | ||
| String schemaMessage = "The document has problems!"; |
There was a problem hiding this comment.
Not necessarily in this pr, but shouldn't the message be configurable?
There was a problem hiding this comment.
This code here is from the tests. Also, the message is the same for any validation error, since:
The schema validation cannot pin-point which part of a rule made it fail
See https://www.arangodb.com/docs/stable/data-modeling-documents-schema-validation.html#error-message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added schema attribute to CollectionPropertiesOptions