[Bugfix] Disable maintenance before healthcheck #299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajanikow
force-pushed
the
bugfix/disable_maintenance_before_healthcheck
branch
from
4174412 to
9904bb4
Compare
neunhoef
requested changes
Aug 26, 2021
There was a problem hiding this comment.
I think this does not solve the problem: It still first restarts the server and then switches Supervision to Maintenance. So in case of high load, there is still the possibility that the server goes down, then the Supervision makes it "BAD" (because of the delay in switching to Maintenance mode), then we switch to Maintenance, and even though the server comes back successfully, it stays "BAD" since the Supervision is in Maintenance mode.
Also: The solution looks overcomplicated, why can withMaintenance not just get two functions as arguments?
neunhoef
approved these changes
Aug 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.