Skip to content

Docs: Enterprise Edition hint box and unified use of name #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 31, 2018
Merged

Docs: Enterprise Edition hint box and unified use of name #185

merged 4 commits into from
Jul 31, 2018

Conversation

Simran-B
Copy link
Collaborator

@ewoutp Should changes to deps/github.com/arangodb/go-driver/ be done in the go driver itself?

@Simran-B Simran-B mentioned this pull request Jul 18, 2018
Merged
@ewoutp
Copy link
Contributor

ewoutp commented Jul 19, 2018

Yes, everything in deps is vendored code. Meaning that it is just copied from their master branches in their respective repos. Any change made in deps without making the same change in the corresponding repo will eventually be lost.

@Simran-B
Copy link
Collaborator Author

Removed changes to deps code, PR is here: arangodb/go-driver#140

@sleto-it
Copy link
Contributor

@Simran-B if you remove the change made in the file help.go I will merge

@sleto-it
Copy link
Contributor

discussed via phone with simran. merging.

@sleto-it sleto-it merged commit d917c62 into arangodb-helper:master Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Simran-B @ewoutp @sleto-it