Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sortir les étapes de validation du MapsManager #657

Merged

Conversation

camillebrianceau
Copy link
Collaborator

@camillebrianceau camillebrianceau commented Sep 26, 2024

In this PR, I aim to remove the validation methods from the Maps Manager:

  • I created a Validator class and moved the validation methods there.
  • I created a ValidatorConfig, although it is not used yet.
  • I added API_test.py, which serves as a model for the desired structure of the API.

Other change for the Validator will be in another PR

@camillebrianceau camillebrianceau changed the base branch from dev to refactoring September 26, 2024 07:40
Copy link

@camillebrianceau camillebrianceau marked this pull request as ready for review September 26, 2024 07:59
Copy link
Collaborator

@thibaultdvx thibaultdvx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

clinicadl/validator/validator.py Outdated Show resolved Hide resolved
@camillebrianceau camillebrianceau merged commit 8a1589e into aramis-lab:refactoring Sep 26, 2024
21 checks passed
@camillebrianceau camillebrianceau deleted the cb_create_validator branch September 26, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants