Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue in compare_folders #610

Merged
merged 9 commits into from
Jun 4, 2024

Conversation

thibaultdvx
Copy link
Collaborator

@thibaultdvx thibaultdvx commented Jun 3, 2024

  1. compare_folders used to not raise an error when it compared two empty directories. So, I added a check to make sure that the two directories to compare do exist. Consequently, I had to solve issues that appear in test_train_ae and test_predict with non existing folders.
  2. I also made changes in test_predict.py and test_random_search.py because the flags introduced in Flag for local tests #608 didn't work well with these tests.
  3. I also added indent in the json files stored in the temporary folders created by the tests.

This PR needs modifications in CI data: because of the bug spotted in 1., the tests of the test_train_ae pipeline used to pass, while some reference data are missing.

@thibaultdvx thibaultdvx changed the title Fix issue in predict tests Fix issue in compare_folders Jun 3, 2024
@thibaultdvx thibaultdvx added the bug Something isn't working label Jun 4, 2024
@thibaultdvx
Copy link
Collaborator Author

thibaultdvx commented Jun 4, 2024

The tests were run with data in aramis-lab/clinicadl_data_ci#38

Copy link
Collaborator

@camillebrianceau camillebrianceau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@thibaultdvx thibaultdvx merged commit f6f382a into aramis-lab:dev Jun 4, 2024
21 checks passed
@thibaultdvx thibaultdvx deleted the fix_issue_in_test_flags branch June 4, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants