-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Run tests through GitHub Actions #573
[CI] Run tests through GitHub Actions #573
Conversation
Here is the result for test_cli: https://github.com/aramis-lab/clinicadl/actions/runs/9111679617/job/25049309668?pr=573 And the one for test_tsvtools: https://github.com/aramis-lab/clinicadl/actions/runs/9111679640/job/25049309674?pr=573 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @NicolasGensollen, thanks a lot! I can take care of the other tests if you want.
Thanks for the review @thibaultdvx ! 👍 |
I'm gonna go ahead and merge this. |
This PR proposes to run the tests through GitHub Actions rather than Jenkins (similar to what we did on Clinica a few months ago).
The VM that was used until now is running on CentOS7 and was clearly missing recent updates.
In addition, CentOS7 will be EOL in June 2024 (https://endoflife.date/centos).
Because of these reasons, I created and configured a new VM running on Ubuntu 20.04-lts.
I should have installed the required tools that we use (like dvc, pipx, poetry, miniconda...) but let me know if something is missing.
I also deployed a new GitHub runner on this VM (there is also one deployed on the CentOS VM but the workflows are crashing due to an old version of glibc, I'll delete it later).
This PR proposes to port two tests:
test_cli.py
andtest_tsvtools.py
to Github Actions, making sure that tests with and without access toclinical_data_ci
are working fine.If the proposed solution is accepted, I'll port the remaining tests and remove the associated Jenkins pipeline.
I will also need to take a closer look at the machine were are using for testing GPU support to see if we could implement something similar.