Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Run tests through GitHub Actions #573

Merged

Conversation

NicolasGensollen
Copy link
Member

@NicolasGensollen NicolasGensollen commented May 15, 2024

This PR proposes to run the tests through GitHub Actions rather than Jenkins (similar to what we did on Clinica a few months ago).

The VM that was used until now is running on CentOS7 and was clearly missing recent updates.
In addition, CentOS7 will be EOL in June 2024 (https://endoflife.date/centos).
Because of these reasons, I created and configured a new VM running on Ubuntu 20.04-lts.
I should have installed the required tools that we use (like dvc, pipx, poetry, miniconda...) but let me know if something is missing.

I also deployed a new GitHub runner on this VM (there is also one deployed on the CentOS VM but the workflows are crashing due to an old version of glibc, I'll delete it later).

This PR proposes to port two tests: test_cli.py and test_tsvtools.py to Github Actions, making sure that tests with and without access to clinical_data_ci are working fine.

If the proposed solution is accepted, I'll port the remaining tests and remove the associated Jenkins pipeline.

I will also need to take a closer look at the machine were are using for testing GPU support to see if we could implement something similar.

@NicolasGensollen NicolasGensollen marked this pull request as ready for review May 16, 2024 12:06
@NicolasGensollen NicolasGensollen self-assigned this May 16, 2024
@NicolasGensollen
Copy link
Member Author

Copy link
Collaborator

@thibaultdvx thibaultdvx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @NicolasGensollen, thanks a lot! I can take care of the other tests if you want.

@NicolasGensollen
Copy link
Member Author

Thanks for the review @thibaultdvx ! 👍
I'll take care of the other tests no worries. I still need to deploy runners on the GPU machine (and maybe an aramis workstation), so I don't mind finishing.
@camillebrianceau is this good for you or do you want to take a closer look before we merge ?

@NicolasGensollen
Copy link
Member Author

I'm gonna go ahead and merge this.
We can always revert if we don't like it in the end...

@NicolasGensollen NicolasGensollen merged commit beccd4c into aramis-lab:dev May 22, 2024
24 checks passed
@NicolasGensollen NicolasGensollen deleted the add-ghaction-workflow branch May 22, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants