[REF] Extract Step 2 of DWIPreprocessingUsingPhasediff into its own workflow
#897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasGensollen
force-pushed
the
extract-dwi-phasediff-step2
branch
from
36f9ece
to
f7551bd
Compare
|
The Jenkins failure is expected as the data needed for the tests aren't merged and uploaded yet. |
MatthieuJoulot
requested changes
Apr 3, 2023
...a/pipelines/dwi_preprocessing_using_fmap/dwi_preprocessing_using_phasediff_fmap_workflows.py
Show resolved
Hide resolved
NicolasGensollen
force-pushed
the
extract-dwi-phasediff-step2
branch
from
f7551bd
to
ef3c471
Compare
MatthieuJoulot
requested changes
Apr 4, 2023
|
Tests are passing with the updated data. |
Co-authored-by: Matthieu Joulot <85217698+MatthieuJoulot@users.noreply.github.com>
|
Thanks for the reviews @MatthieuJoulot ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #893 for Step 1, this PR proposes to extract the Step 2 of the
DWIPreprocessingUsingPhaseDiffpipeline into its own workflow:calibrate_and_register_fmapThis PR also proposes to add functional tests for the extracted workflow in isolation.
The added test is classified as "fast" as it is running in about 1 minute. It requires the data I have generated here: https://github.com/aramis-lab/clinica_data_ci/pull/29