Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Fix logging in OASIS and AIBL converters #1340

Merged
merged 1 commit into from
Oct 17, 2024
Merged

[FIX] Fix logging in OASIS and AIBL converters #1340

merged 1 commit into from
Oct 17, 2024

Conversation

AliceJoubert
Copy link
Contributor

Same fix as #1181

@AliceJoubert AliceJoubert added converter fix PR fixing a bug labels Oct 17, 2024
@AliceJoubert AliceJoubert self-assigned this Oct 17, 2024
NicolasGensollen
NicolasGensollen approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@NicolasGensollen NicolasGensollen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @AliceJoubert !

@NicolasGensollen NicolasGensollen merged commit cd447d5 into aramis-lab:dev Oct 17, 2024
13 of 15 checks passed
@AliceJoubert AliceJoubert deleted the conv_logging branch October 17, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasGensollen NicolasGensollen NicolasGensollen approved these changes

Assignees

@AliceJoubert AliceJoubert

Labels
converter fix PR fixing a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AliceJoubert @NicolasGensollen