Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* wayland/ui_display.c: Fix implicit function decl. #105

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

tsutsui
Copy link
Contributor

@tsutsui tsutsui commented Aug 13, 2024

Fixes the following warning:

../uitoolkit/wayland/ui_display.c: In function 'ui_display_open':
../uitoolkit/wayland/ui_display.c:2748:5: warning: implicit declaration of function 'ui_event_source_add_fd' [-Wimplicit-function-declaration]
 2748 |     ui_event_source_add_fd(-10, auto_repeat);
      |     ^~~~~~~~~~~~~~~~~~~~~~

Note this "implicit function declaration" warning is treated as a fatal error on archLinux with gcc14.

@tsutsui
Copy link
Contributor Author

tsutsui commented Aug 13, 2024

Note gcc14 on archLinux complains further:

 vte.c: In function 'search_find':
vte.c:408:57: error: pointer type mismatch in conditional expression [-Wincompatible-pointer-types]
  408 |   regex = PVT(terminal)->gregex ? PVT(terminal)->gregex : PVT(terminal)->vregex;
      |                                                         ^
vte.c:212:23: note: first expression has type 'GRegex *' {aka 'struct _GRegex *'}
  212 | #define PVT(terminal) ((VteTerminalPrivate*)(terminal)->_unused_padding[0])
      |                       ^
vte.c:408:35: note: in expansion of macro 'PVT'
  408 |   regex = PVT(terminal)->gregex ? PVT(terminal)->gregex : PVT(terminal)->vregex;
      |                                   ^~~
vte.c:212:23: note: second expression has type 'VteRegex *' {aka 'struct _VteRegex *'}
  212 | #define PVT(terminal) ((VteTerminalPrivate*)(terminal)->_unused_padding[0])
      |                       ^
vte.c:408:59: note: in expansion of macro 'PVT'
  408 |   regex = PVT(terminal)->gregex ? PVT(terminal)->gregex : PVT(terminal)->vregex;
      |                                                           ^~~

(I'm testing Linux CI using docker and will send a pullup request)

@arakiken arakiken merged commit 7ccfc94 into arakiken:master Aug 14, 2024
3 checks passed
@arakiken
Copy link
Owner

Thanks.

@arakiken
Copy link
Owner

Fix error in vte.c -> 5b131b7

@tsutsui tsutsui deleted the fix-wayland-implicit-decl branch August 14, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants