Skip to content

fix: Address workspaces review results - #1482

Open
milosh86 wants to merge 4 commits into
app-1140-v1-of-workspaces-supporting-multiple-daosfrom
review-results-updates
Open

milosh86 wants to merge 4 commits into
app-1140-v1-of-workspaces-supporting-multiple-daosfrom
review-results-updates

Conversation

@milosh86

Copy link
Copy Markdown
Contributor

Description

Follow-up fixes from the workspaces review.

  • Feature flag gating: LayoutWorkspace, LayoutWorkspaceAccount and LayoutWizardCreateWorkspace now check the workspaces flag and return notFound(). Before this, only the pages were gated, so with the flag off the layouts still rendered the workspace navigation, the gate and the wizard around the 404, and still prefetched from the backend. Docs in createWorkspace.md updated.
  • useWorkspaceDaos cache corruption: the hook used to mutate the DAO object from the shared daoOptions cache when applying the workspace account metadata (name, avatar, description), so the overrides leaked into the rest of the app. It now builds a copy. It also looks up the account by the query's id instead of dao.id.
  • Proposals page: the "New proposal" action is hidden until the workspace DAOs have loaded.
  • Publish workspace dialog: exported through next/dynamic, like the other dialogs.

Type of Change

  • Patch: Bug fix (non-breaking change which fixes an issue)

Developer Checklist:

  • Manually smoke tested the functionality in a preview or locally
  • Confirmed there are no new warnings or errors in the browser console
  • (For User Stories only) Double-checked that all Acceptance Criteria are satisfied
  • Confirmed there are no new warnings on automated tests
  • Merged and published any dependent changes in downstream modules
  • Selected the correct base branch
  • Commented the code in hard-to-understand areas
  • Followed the code style guidelines of this project
  • Reviewed that the Files Changed in Github’s UI reflect my intended changes
  • Confirmed the pipeline checks are not failing

Review Checklist:

  • (For User Stories only) Tested in a preview or locally that all Acceptance Criteria are satisfied
  • Confirmed that changes follow the code style guidelines of this project

Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
@github-actions

Copy link
Copy Markdown

🚀 Preview Deployment: View Here

@milosh86
milosh86 marked this pull request as ready for review October 12, 2026 07:36
@milosh86
milosh86 requested a review from a team as a code owner October 12, 2026 07:36
@github-actions

Copy link
Copy Markdown

E2E results (preview)

Smoke

Base URL https://app-next-63j291k8a-aragon-app.vercel.app
Suite smoke
Playwright result ✅ passed
Summary 86 passed
HTML report View report
GitHub job ✅ completed

View run #5512

<Page.Main
action={
daoAccounts.length > 0
daoAccounts.length > 0 && !isDaosPending

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we keep accounts without a resolved DAO out of this flow, the way the transactions page does? A rejected DAO query clears isDaosPending, so the button reappears and picking that account dead-ends in an empty process dialog.

This branch was successfully deployed

1 active deployment
preview — fabbcae1 Deployed Oct 12, 2026 by milosh86 via deploy / deploy #5512
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants