Repository navigation
Conversation
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
|
🚀 Preview Deployment: View Here |
milosh86
marked this pull request as ready for review
October 12, 2026 07:36
|
E2E results (preview) Smoke
|
| <Page.Main | ||
| action={ | ||
| daoAccounts.length > 0 | ||
| daoAccounts.length > 0 && !isDaosPending |
Contributor
There was a problem hiding this comment.
Could we keep accounts without a resolved DAO out of this flow, the way the transactions page does? A rejected DAO query clears isDaosPending, so the button reappears and picking that account dead-ends in an empty process dialog.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up fixes from the workspaces review.
LayoutWorkspace,LayoutWorkspaceAccountandLayoutWizardCreateWorkspacenow check theworkspacesflag and returnnotFound(). Before this, only the pages were gated, so with the flag off the layouts still rendered the workspace navigation, the gate and the wizard around the 404, and still prefetched from the backend. Docs increateWorkspace.mdupdated.useWorkspaceDaoscache corruption: the hook used to mutate the DAO object from the shareddaoOptionscache when applying the workspace account metadata (name, avatar, description), so the overrides leaked into the rest of the app. It now builds a copy. It also looks up the account by the query'sidinstead ofdao.id.next/dynamic, like the other dialogs.Type of Change
Developer Checklist:
Review Checklist: