Skip to content

feat: Add cross-chain controller permissions to permission names list - #1443

Merged
Fabricevladimir merged 4 commits into
mainfrom
feat/add-cross-chain-controller-permissions
Oct 6, 2026
Merged

Fabricevladimir merged 4 commits into
mainfrom
feat/add-cross-chain-controller-permissions

Conversation

@Fabricevladimir

@Fabricevladimir Fabricevladimir commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Description

This PR adds the permisssions associated with the Crosschain Controller Plugin & its corresponding Chain ID Registry contract.

Type of Change

  • Patch: Enhancement (non-breaking change to an existing feature)

Developer Checklist:

  • Manually smoke tested the functionality in a preview or locally
  • Confirmed there are no new warnings or errors in the browser console
  • (For User Stories only) Double-checked that all Acceptance Criteria are satisfied
  • Confirmed there are no new warnings on automated tests
  • Merged and published any dependent changes in downstream modules
  • Selected the correct base branch
  • Commented the code in hard-to-understand areas
  • Followed the code style guidelines of this project
  • Reviewed that the Files Changed in Github’s UI reflect my intended changes
  • Confirmed the pipeline checks are not failing

Review Checklist:

  • (For User Stories only) Tested in a preview or locally that all Acceptance Criteria are satisfied
  • Confirmed that changes follow the code style guidelines of this project

@Fabricevladimir
Fabricevladimir requested a review from a team as a code owner October 1, 2026 13:51
@Fabricevladimir

Fabricevladimir commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor Author

Check that all permissions render for the Cross-chain Controller Plugin and Registry using the makina-susd-guardians.dao.eth

@github-actions

github-actions Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

🚀 Preview Deployment: View Here

@github-actions

github-actions Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

E2E results (preview)

Smoke

Base URL https://app-next-lveqegd6i-aragon-app.vercel.app
Suite smoke
Playwright result ✅ passed
Summary 86 passed
HTML report View report
GitHub job ✅ completed

View run #5404

@Fabricevladimir
Fabricevladimir force-pushed the feat/add-cross-chain-controller-permissions branch from 7ce27f4 to 122836b Compare October 1, 2026 14:59
Comment thread apps/app/src/shared/utils/permissionNameUtils/permissionNameUtils.ts Outdated
Comment thread .changeset/app-cross-chain-controller-permission-names.md Outdated

@thekidnamedkd thekidnamedkd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Fabricevladimir
Fabricevladimir merged commit 1b383cc into main Oct 6, 2026
23 checks passed
@Fabricevladimir
Fabricevladimir deleted the feat/add-cross-chain-controller-permissions branch October 6, 2026 13:20

This branch was successfully deployed

1 active deployment
preview — 7645fc95 Deployed Oct 5, 2026 by Fabricevladimir via deploy / deploy #5404
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants