Fix jenkinscheck not populating consecutive_failures

Jenkins checks were always passing due to a bug in 0.11.12

CHANGES

@@ -1,6 +1,7 @@
 master
 ------
 
+* Fix bug where jenkins checks were always passing
 * Reduce Arachnys branding a bit
 * Fix 404 page for logged out users
 * Style forms with django-bootstrap-form

cabot/cabotapp/models/jenkins_check_plugin.py

@@ -23,6 +23,7 @@ def _run(self):
             status = get_job_status(self.jenkins_config, self.name)
             active = status['active']
             result.job_number = status['job_number']
+            result.consecutive_failures = status['consecutive_failures']
             if status['status_code'] == 404:
                 result.error = u'Job %s not found on Jenkins' % self.name
                 result.succeeded = False

cabot/cabotapp/tests/tests_jenkins.py

@@ -6,6 +6,7 @@
 import jenkins
 from cabot.cabotapp import jenkins as cabot_jenkins
 from cabot.cabotapp.models import JenkinsConfig
+from cabot.cabotapp.models.jenkins_check_plugin import JenkinsStatusCheck
 from django.utils import timezone
 from freezegun import freeze_time
 from mock import create_autospec, patch
@@ -67,17 +68,19 @@ def test_job_failing(self, mock_jenkins):
             u'result': u'SUCCESS'
         }
 
-        status = cabot_jenkins.get_job_status(self.mock_config, 'foo')
-
-        expected = {
-            'active': True,
-            'succeeded': False,
-            'job_number': 12,
-            'blocked_build_time': None,
-            'consecutive_failures': 1,
-            'status_code': 200
-        }
-        self.assertEqual(status, expected)
+        jenkins_check = JenkinsStatusCheck(
+            name="foo",
+            jenkins_config=JenkinsConfig(
+                name="name",
+                jenkins_api="a",
+                jenkins_user="u",
+                jenkins_pass="p"
+            )
+        )
+        result = JenkinsStatusCheck._run(jenkins_check)
+
+        self.assertEqual(result.consecutive_failures, 1)
+        self.assertFalse(result.succeeded)
 
     @freeze_time('2017-03-02 10:30')
     @patch("cabot.cabotapp.jenkins._get_jenkins_client")